Conversation
wwysoc2
left a comment
wwysoc2
left a comment
There was a problem hiding this comment.
- I'm setting to "request changes" so we remember to add the link if possible
- This looks good, I'm okay with the release notes going out like this, but I would like a once over from a dev. I don't think anything is protected, but there are a few technical details that I would like to make sure are okay to let users know about.
|
|
||
| ### New Features and Changes | ||
|
|
||
| * Legacy clinical and sample properties that were removed from the GDC Dictionary in the prior release are now also removed from the API and no longer accessible or visible in the portal. <!-- DEV-3629 --> |
There was a problem hiding this comment.
I think we planned on documenting these in the portal release notes. I'm not sure if they are there yet, but could we link there once we have those release notes ready?
There was a problem hiding this comment.
The portal release notes with the list of removed props are still in PR, but the template is in and you should be able to link to it with something like (/Data_Portal/Release_Notes/Data_Portal_Release_Notes#release-260)
note that I couldn't find a stable way to link to a subsection of a specific release's notes.
| ### Bugs Fixed Since Last Release | ||
|
|
||
| * Context ID is now sent from gdcapi to cohortapi using the Gdc-Context-Id request header instead of context_id, fixing context ID errors without changing any public gdcapi cohort endpoints. <!-- DEV-3822 --> | ||
| * The GraphQL API now returns available_variation_data as a proper list of strings instead of a literal string, resolving type errors introduced by the graphene upgrade. <!-- DEV-3756 --> |
There was a problem hiding this comment.
Could you check on this on? I'm not sure if the bug was ever released -- IIRC, the graphene update was done for uhlenbeck. if it was never released, then I don't think the fix needs to be in release notes.
There was a problem hiding this comment.
discussed with Micky - the change will be visible to users, so I think we should have a release note for it
+updated the description
There was a problem hiding this comment.
Lemme dig a bit. If it used to return a string and now a list of strings, I'm surprised it's not breaking a bunch of queries in the portal or elsewhere (unless we got very lucky).
3 participants
DOC-512: Uhlenbeck API Release Notes