[DTOSS-8589] Container app modules #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
force-pushed
the
DTOSS-8589-container-app-module
branch
4 times, most recently
from
8b9494f to
60299bf
Compare
Add terraform-docs command to terraform makefile to generate for all the modules in the infrastructure directory
The linters throw too many false positives
- Link to generated tfdoc - Link to examples directory if it exists - List all modules from top README
saliceti
force-pushed
the
DTOSS-8589-container-app-module
branch
from
60299bf to
94e4e61
Compare
josielsouzanordcloud
approved these changes
May 9, 2025
Contributor
josielsouzanordcloud
left a comment
josielsouzanordcloud
left a comment
There was a problem hiding this comment.
Code peer reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce modules to support container app hosting, following ADR-24
Added READMEs to the new modules
Added terraform docs and basic README to all modules
Updated root README
Context
Offer an alternative to function apps for web applications and HTTP APIs.
How to review
Test with branch
DTOSS-8324-container-app-moduleon https://github.com/nhsdigital/manage-breast-screening by running terraform from AVDIt deploys a container app with the latest docker image from GHCR
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.