Fix RUN_NOTIFICATIONS_SMOKE_TEST variable check
#740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
force-pushed
the
fix-notifications-smoke-test-conditional
branch
from
8f1ea10 to
b041e19
Compare
steventux
force-pushed
the
fix-notifications-smoke-test-conditional
branch
from
b041e19 to
75a22d9
Compare
steventux
force-pushed
the
fix-notifications-smoke-test-conditional
branch
from
75a22d9 to
8d39d1a
Compare
steventux
force-pushed
the
fix-notifications-smoke-test-conditional
branch
from
8d39d1a to
4a15d39
Compare
steventux
force-pushed
the
fix-notifications-smoke-test-conditional
branch
from
4a15d39 to
07c5789
Compare
steventux
force-pushed
the
fix-notifications-smoke-test-conditional
branch
from
07c5789 to
194ffad
Compare
|
The review app at this URL has been deleted: |
We don't want to deploy the notifications smoke_test job when the environment doesn't run the smoke test. We want to deploy all other container app jobs regardless.
steventux
force-pushed
the
fix-notifications-smoke-test-conditional
branch
from
0ff1311 to
e017ade
Compare
steventux
changed the title
RUN_NOTIFICATIONS_SMOKE_TEST variable check
saliceti
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of conditionals which control what gets provisioned and run when
$RUN_NOTIFICATIONS_SMOKE_TESTis true or false.RUN_NOTIFICATIONS_SMOKE_TESTvariable is set tofalse.true.false.true.Configured to skip smoke test
https://dev.azure.com/nhse-dtos/dtos-manage-breast-screening/_build/results?buildId=30531&view=results
Configured to run smoke test
https://dev.azure.com/nhse-dtos/dtos-manage-breast-screening/_build/results?buildId=30526&view=results
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11296
Review notes
Review checklist