Guard against blank PR number being passed to test #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise results in the wrong container app name and environment being configured and called.
josielsouzanordcloud
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://screening-discovery.slack.com/archives/C07QHFSV79U/p1763636686675789 for context
We are seeing the wrong container app name and environment being configured and called because the ADO pipeline job is passed a blank
prNumbervalue (or perhaps this is a default in ADO?)eg.
This causes the setup of the smoke test to attempt to use the blank value in the resource group, storage account and container app job name.
This PR ensures we ignore a blank value and use the underlying environment name.
Jira link
https://screening-discovery.slack.com/archives/C07QHFSV79U/p1763636686675789
Review notes
Review checklist