Export ENVIRONMENT prior to running smoke test
#748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
reviewed
Nov 20, 2025
steventux
force-pushed
the
export-environment-to-smoke-test
branch
from
e8ab3ff to
8452189
Compare
saliceti
approved these changes
Nov 20, 2025
|
The review app at this URL has been deleted: |
The review environment exports ENVIRONMENT and the smoke test defaults to dev when looking up this environment variable. So the smoke test passes for these environments but fails on preprod as the variable is not set. Ensure we export it prior to running the test. Removes some logic around PR_NUMBER and storage account details as these aren't required anymore.
steventux
force-pushed
the
export-environment-to-smoke-test
branch
from
8452189 to
5d3b6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The review environment exports
$ENVIRONMENTand the smoke test defaults todevwhen looking up this environment variable. Hence the smoke test passes for these environments but fails on preprod as the variable is not set.Ensure we export it prior to running the test.
Jira link
Review notes
Review checklist