Add link to delete appointment notes #823
Conversation
- Put appointment note view logic into its own file - Add a view dealing with note deletion, including a confirmation step
If a user clicks on a stale delete link for an appointment note that has already been deleted, simply redirect them back to the note tab.
malcolmbaig
force-pushed
the
11725-delete-note
branch
from
914174e to
1810cb9
Compare
|
|
||
| @property | ||
| def instance_is_saved(self): | ||
| return self.instance and not self.instance._state.adding |
There was a problem hiding this comment.
could this be simplified to self.instance.pk is not None?
_state just looks a bit iffy to me as it normally indicates private fields, although it is part of the documented API in this case. OK to leave it as is if you prefer.
There was a problem hiding this comment.
Started off as that but it looks like Django assigns uuid primary keys at instantiation time so this check wasn't working as intended.
|
|
||
| def get_success_url(self): | ||
| return reverse("mammograms:appointment_note", kwargs={"pk": self.kwargs["pk"]}) | ||
|
|
There was a problem hiding this comment.
Can this logic be moved into the superclass do you think? I've just added something similar for add and update in this PR #824
There was a problem hiding this comment.
Do you mean in DeleteWithAuditView? Worth considering — would be interested in seeing what that looks like.
2 participants
Description
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11725
Review notes
na
Review checklist