Skip to content

Conversation

@ayeshalshukri1-nhs
Copy link
Contributor

@ayeshalshukri1-nhs ayeshalshukri1-nhs commented May 29, 2025

Description

Added an additional test case to cover person who is not in any cohorts.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you, but I find they type annotations useful.

@Karthikeyannhs Karthikeyannhs self-assigned this May 29, 2025
@ayeshalshukri1-nhs ayeshalshukri1-nhs merged commit a929fae into main May 29, 2025
24 checks passed
@ayeshalshukri1-nhs ayeshalshukri1-nhs deleted the feature/eli-222-magic-cohort-added-test-cases branch May 29, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants