Skip to content

Added additional test case. #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayeshalshukri1-nhs merged 3 commits into from
May 29, 2025
Merged

Added additional test case. #105

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0ce5f7
Added addtional test case.
ayeshalshukri1-nhs May 29, 2025
7c7d9c5
Update tests/unit/services/calculators/test_eligibility_calculator.py
ayeshalshukri1-nhs May 29, 2025
28f8d36
linting fixed.
ayeshalshukri1-nhs May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions tests/unit/services/calculators/test_eligibility_calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,25 +47,28 @@ def test_not_base_eligible(faker: Faker):


@pytest.mark.parametrize(
("cohorts", "test_comment"),
("person_cohorts", "iteration_cohorts", "test_comment"),
[
(["elid_all_people"], "Only magic cohort present"),
(["elid_all_people", "cohort1"], "Magic cohort with other cohorts"),
(["cohort1"], ["elid_all_people"], "Only magic cohort present"),
(["cohort1"], ["elid_all_people", "cohort1"], "Magic cohort with other cohorts"),
([], ["elid_all_people"], "Only magic cohort present without "),
],
)
def test_base_eligible_with_when_magic_cohort_is_present(faker: Faker, cohorts, test_comment):
def test_base_eligible_with_when_magic_cohort_is_present(
faker: Faker, person_cohorts: list[str], iteration_cohorts: list[str], test_comment: str
):
# Given
nhs_number = NHSNumber(faker.nhs_number())
date_of_birth = DateOfBirth(faker.date_of_birth(minimum_age=76, maximum_age=79))

person_rows = person_rows_builder(nhs_number, date_of_birth=date_of_birth, cohorts=["cohort1"])
person_rows = person_rows_builder(nhs_number, date_of_birth=date_of_birth, cohorts=person_cohorts)
campaign_configs = [
rule_builder.CampaignConfigFactory.build(
target="RSV",
iterations=[
rule_builder.IterationFactory.build(
iteration_cohorts=[
rule_builder.IterationCohortFactory.build(cohort_label=label) for label in cohorts
rule_builder.IterationCohortFactory.build(cohort_label=label) for label in iteration_cohorts
],
iteration_rules=[rule_builder.PersonAgeSuppressionRuleFactory.build()],
)
Expand Down
Loading