Skip to content

Conversation

@acerathereinspirative-nhs-nvir
Copy link
Contributor

@acerathereinspirative-nhs-nvir acerathereinspirative-nhs-nvir commented Feb 18, 2025

Description

Update pyproject.toml for current versions of Python and Poetry.

Add Makefile targets for linting and formatting, and plug tests into the existing test and integration targets.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Collaborator

@eddalmond1 eddalmond1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested bump of poetry version + changes to packages etc. via codespace and was able to build successfully. I used pyenv to ensure there was a 3.13 env available to test, and we should be able to do this locally - something to add to the readme perhaps

@acerathereinspirative-nhs-nvir acerathereinspirative-nhs-nvir force-pushed the chore/poetry-2-and-python-313 branch 3 times, most recently from 5bd21f1 to 13d083d Compare February 19, 2025 10:46
@acerathereinspirative-nhs-nvir acerathereinspirative-nhs-nvir force-pushed the chore/poetry-2-and-python-313 branch 2 times, most recently from 63ac7c8 to ec1ead3 Compare February 19, 2025 14:54
@eddalmond1 eddalmond1 merged commit 5623f92 into main Feb 19, 2025
23 checks passed
@acerathereinspirative-nhs-nvir acerathereinspirative-nhs-nvir deleted the chore/poetry-2-and-python-313 branch February 20, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants