VED-808 (Child of VED-720) Refactor quality check pipeline #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-808 |
dlzhry2nhs
force-pushed
the
feature/VED-808-refactor-pr-quality-checks
branch
5 times, most recently
from
7e7b1fc to
2a1708b
Compare
dlzhry2nhs
force-pushed
the
feature/VED-808-refactor-pr-quality-checks
branch
from
2a1708b to
eb2475f
Compare
dlzhry2nhs
commented
Sep 24, 2025
dlzhry2nhs
requested review from
Akol125,
JamesW1-NHS,
mfjarvis and
nhsdevws
mfjarvis
reviewed
Sep 24, 2025
mfjarvis
reviewed
Sep 24, 2025
mfjarvis
reviewed
Sep 24, 2025
mfjarvis
previously approved these changes
Sep 24, 2025
dlzhry2nhs
commented
Sep 24, 2025
.github/workflows/pr-jira-link.yaml
Outdated
| if: contains(github.event.pull_request.head.ref, 'amb-') || contains(github.event.pull_request.head.ref, 'AMB-') || contains(github.event.pull_request.head.ref, 'ambspii-') || contains(github.event.pull_request.head.ref, 'AMBSPII-') || contains(github.event.pull_request.head.ref, 'adz-') || contains(github.event.pull_request.head.ref, 'ADZ-') || contains(github.event.pull_request.head.ref, 'ved-') || contains(github.event.pull_request.head.ref, 'VED-') | ||
| continue-on-error: true | ||
| uses: unsplash/comment-on-pr@master | ||
| uses: unsplash/comment-on-pr@b5610c6125a7197eaec80072ea35ef53e1fc6035 |
Contributor
Author
There was a problem hiding this comment.
I have aligned this to the commit of the latest version. Dependabot should bump when we need to.
I added this, because Sonarcloud stipulates that we need to pin to specific commit hashes rather than versions.
JamesW1-NHS
previously approved these changes
Sep 24, 2025
mfjarvis
approved these changes
Sep 24, 2025
|
mfjarvis
pushed a commit
that referenced
this pull request
Oct 22, 2025
mfjarvis
pushed a commit
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mostly renames workflows to what they actually do. A few are inherited ones from the APIM starter repo.
Also pins Action dependencies to commit hashes and secures the PR Link job based on Sonarcloud feedback.
Added a linting job to Github Actions so we can get quick feedback rather than waiting for the APIM pipeline, and ensures we will still have the check for if/when we fully move away.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.