Remove old linting code. Add Terraform to tool versions file. #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-000 |
mfjarvis
force-pushed
the
VED-000-remove-old-linting-code
branch
from
65a73c5 to
caa315c
Compare
mfjarvis
commented
Oct 10, 2025
| @@ -1 +1 @@ | |||
| 1.6.4 | |||
Contributor
Author
There was a problem hiding this comment.
This is used by the Azure pipelines (who knew?). Can be removed once we fully switch over to the GitHub Actions pipelines, which explicitly install the correct version of Terraform.
JamesW1-NHS
approved these changes
Oct 10, 2025
dlzhry2nhs
approved these changes
Oct 10, 2025
|
mfjarvis
added a commit
that referenced
this pull request
Oct 22, 2025
* Remove old linting code. Add Terraform to tool versions file for asdf / mise users. * Update quality checks pipeline. * Update dist included files. * Remove unnecessary pipeline step and template. * Reinstate .terraform-version while we're still using APIM pipelines.
mfjarvis
added a commit
that referenced
this pull request
Oct 27, 2025
* Remove old linting code. Add Terraform to tool versions file for asdf / mise users. * Update quality checks pipeline. * Update dist included files. * Remove unnecessary pipeline step and template. * Reinstate .terraform-version while we're still using APIM pipelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.