VED-000 Improve tf stability on first apply

[dlzhry2nhs]

Summary

• Routine Change

The Azure pipelines would retry the terraform apply step twice, and I think that was papering over some cracks.

On retry it is okay, but the first time building a completely fresh environment almost always seems to fail with:

Solution:

• include a hard dependency on the policy attachment being in place. There is a race condition where the role exists and you attempt to create the event bridge pipe, but it does not yet have the required policy attached to the actual role.
• also saw one instance of the config notification bucket failing. I would have thought it would already have a dependency on that Lambda function. Anyway, making the dependency explicit caused the pipeline to work first time.

Reviews Required

• Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

• I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
• If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
• I have ensured the changelog has been updated by the submitter, if necessary.

[github-actions]

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-000

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud