Skip to content

VED-000 Improve tf stability on first apply #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlzhry2nhs merged 3 commits into from
Oct 21, 2025
Merged

VED-000 Improve tf stability on first apply #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85120af
Attempt to fix terraform instability on first apply
dlzhry2nhs Oct 21, 2025
6ee3b81
Try fix, although need to destroy and retry fresh after
dlzhry2nhs Oct 21, 2025
d70f79a
Merge branch 'master' into feature/VED-000-improve-tf-stability
dlzhry2nhs Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions infrastructure/instance/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ destroy: workspace
$(tf_cmd) workspace select default
$(tf_cmd) workspace delete $(sub_environment)

graph: workspace
$(tf_cmd) graph

output:
$(tf_cmd) output -raw $(name)

Expand Down
5 changes: 5 additions & 0 deletions infrastructure/instance/ecs_batch_processor_config.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ resource "aws_iam_role" "fifo_pipe_role" {
]
})
}

resource "aws_iam_policy" "fifo_pipe_policy" {
name = "${local.short_prefix}-fifo-pipe-policy"
policy = jsonencode({
Expand Down Expand Up @@ -356,6 +357,10 @@ resource "aws_pipes_pipe" "fifo_pipe" {
log_group_arn = aws_cloudwatch_log_group.pipe_log_group.arn
}
}

depends_on = [
aws_iam_role_policy_attachment.fifo_pipe_policy_attachment
]
}

# Custom Log Group
Expand Down
4 changes: 4 additions & 0 deletions infrastructure/instance/redis_sync_lambda.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,10 @@ resource "aws_s3_bucket_notification" "config_lambda_notification" {
lambda_function_arn = aws_lambda_function.redis_sync_lambda.arn
events = ["s3:ObjectCreated:*"]
}

depends_on = [
aws_lambda_function.redis_sync_lambda
]
}

# Permission for the new S3 bucket to invoke the Lambda function
Expand Down