Ensure commas in school names don't break csv files #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
doesn't work for systmone files, I need to take a look |
Collaborator
Author
|
All good! |
chinmaymudholkar1
approved these changes
Jun 25, 2025
Collaborator
chinmaymudholkar1
left a comment
chinmaymudholkar1
left a comment
There was a problem hiding this comment.
While this is ok for the time-being, it would be better to export the CSVs from a dataframe which will take care of quotes for all fields in all files automatically. I will create an issue for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ensures school names are surround by double quotes, so if they contain commas they do not break the csv