Skip to content

Ensure commas in school names don't break csv files #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jf-x-dev merged 2 commits into from
Jun 25, 2025
Merged

Ensure commas in school names don't break csv files #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a48225
ensure commas in school names don't break csv files
jf-x-dev Jun 25, 2025
3861574
fix csvs for systmone tests
jf-x-dev Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mavis/test/data/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def create_file_from_template(

if self.schools:
for index, school in enumerate(self.schools):
static_replacements[f"<<SCHOOL_{index}_NAME>>"] = school.name
static_replacements[f"<<SCHOOL_{index}_NAME>>"] = f'"{school.name}"'
static_replacements[f"<<SCHOOL_{index}_URN>>"] = school.urn

if self.nurse:
Expand Down
2 changes: 1 addition & 1 deletion mavis/test/data/vaccs/i_systmone_hist_negative.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ InvalidEventDate,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RAND
FutureEventDate,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,20350219,School,<<VACCS_TIME>>,<<ORG_CODE>>,<<SCHOOL_0_NAME>>,<<SCHOOL_0_URN>>,
PastEventDate,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,20050219,School,<<VACCS_TIME>>,<<ORG_CODE>>,<<SCHOOL_0_NAME>>,<<SCHOOL_0_URN>>,
InvalidEventTime,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,<<HIST_VACCS_DATE>>,School,25:00:00,<<ORG_CODE>>,<<SCHOOL_0_NAME>>,<<SCHOOL_0_URN>>,
InvalidSchoolURN,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,<<HIST_VACCS_DATE>>,School,<<VACCS_TIME>>,<<ORG_CODE>>,<<SCHOOL_0_NAME>>1,000000,
InvalidSchoolURN,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,<<HIST_VACCS_DATE>>,School,<<VACCS_TIME>>,<<ORG_CODE>>,<<SCHOOL_0_NAME>>,000000,
4 changes: 2 additions & 2 deletions mavis/test/data/vaccs/i_systmone_negative.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ FutureEventDate,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDO
PastEventDate,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,20050219,School,<<VACCS_TIME>>,<<ORG_CODE>>,<<SCHOOL_0_NAME>>,<<SCHOOL_0_URN>>,
InvalidEventTime,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,<<VACCS_DATE>>,School,25:00:00,<<ORG_CODE>>,<<SCHOOL_0_NAME>>,<<SCHOOL_0_URN>>,
FutureEventTime,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,<<VACCS_DATE>>,School,23:59:00,<<ORG_CODE>>,<<SCHOOL_0_NAME>>,<<SCHOOL_0_URN>>,
InvalidSchoolURN,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,<<VACCS_DATE>>,School,<<VACCS_TIME>>,<<ORG_CODE>>,<<SCHOOL_0_NAME>>1,000000,
LongBatchNumber,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,<<VACCS_DATE>>,School,<<VACCS_TIME>>,<<ORG_CODE>>,<<SCHOOL_0_NAME>>1,000000,
InvalidSchoolURN,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,123013325,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,<<VACCS_DATE>>,School,<<VACCS_TIME>>,<<ORG_CODE>>,<<SCHOOL_0_NAME>>,000000,
LongBatchNumber,<<DOB_YEAR_10>>,<<RANDOM_NHS_NO>>,,12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901,,Cervarix 1,<<RANDOM_FNAME>>,LE3 2DA,Female,<<RANDOM_LNAME>>,<<VACCS_DATE>>,School,<<VACCS_TIME>>,<<ORG_CODE>>,<<SCHOOL_0_NAME>>,000000,