Skip to content

NPA-4693 Fix MISSING_REFERENCE_CODE Sandbox Response#186

Merged
JackPlowman merged 1 commit intomasterfrom
dev/NPA-4693_Fix_Sandbox
Apr 11, 2025
Merged

NPA-4693 Fix MISSING_REFERENCE_CODE Sandbox Response#186
JackPlowman merged 1 commit intomasterfrom
dev/NPA-4693_Fix_Sandbox

Conversation

@JackPlowman
Copy link
Contributor

@JackPlowman JackPlowman commented Apr 11, 2025

Pull Request

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-4693

Description/Change Summary

  • Fix Sandbox to return correct status code when reference code is missing

How to test?

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@JackPlowman JackPlowman added bug Something isn't working python Pull requests that update Python code labels Apr 11, 2025
@JackPlowman JackPlowman self-assigned this Apr 11, 2025
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4693

@JackPlowman JackPlowman force-pushed the dev/NPA-4693_Fix_Sandbox branch from c473a89 to c8e2f01 Compare April 11, 2025 14:01
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4693

@JackPlowman JackPlowman changed the title NPA-4693 Fix Sandbox Response NPA-4693 Fix MISSING_REFERENCE_CODE Sandbox Response Apr 11, 2025
@JackPlowman JackPlowman merged commit 358d6a0 into master Apr 11, 2025
16 checks passed
@JackPlowman JackPlowman deleted the dev/NPA-4693_Fix_Sandbox branch April 11, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants