Skip to content

NPA-4693 Fix MISSING_REFERENCE_CODE Sandbox Response #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackPlowman merged 1 commit into from
Apr 11, 2025
Merged

NPA-4693 Fix MISSING_REFERENCE_CODE Sandbox Response #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sandbox/api/get_questionnaire_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def get_questionnaire_response_response() -> Union[dict, tuple]:
elif reference_code == "INVALID":
return generate_response_from_example(GET_QUESTIONNAIRE_RESPONSE__INVALID, 400)
elif reference_code == "" or reference_code is None:
return generate_response_from_example(GET_QUESTIONNAIRE_RESPONSE__MISSING, 404)
return generate_response_from_example(GET_QUESTIONNAIRE_RESPONSE__MISSING, 400)
elif reference_code == "ABC123XY":
return generate_response_from_example(GET_QUESTIONNAIRE_RESPONSE__NOT_FOUND, 404)
else:
Expand Down
2 changes: 1 addition & 1 deletion sandbox/api/tests/test_get_questionnaire_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
(
"referenceCode=",
"./api/examples/GET_QuestionnaireResponse/errors/missing_reference_code.yaml",
404,
400,
),
(
"referenceCode=ABC123XY",
Expand Down