Merged
Conversation
RoyStegeman
force-pushed
the
add_faketheoryid
branch
from
be13cdf to
9ca3065
Compare
RoyStegeman
force-pushed
the
add_faketheoryid
branch
from
04aa5c9 to
a588239
Compare
scarlehoff
approved these changes
Mar 17, 2025
RoyStegeman
force-pushed
the
add_faketheoryid
branch
from
a588239 to
1ce259d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For closure testing the CRM we need a
faketheoryidthat defines which theory to use during the generation of the L0 data.Another possible solution (that Andrea chose at the time, but was never merged) is to introduce a
data_level0which replaces the usualdatathat is given as input to the relevant closure test actions (since the fktables are part of the data class object). Sincefaketheoryidis only needed in vp-setupfit I think this solution is a bit simpler/cleaner.The second commit intends to make
SetupFitConfigmore readable but doesn't change any functionality.I didn't touch the closuretstmetric section or the th covmat section since those will be changed in the ongoing incosistent closure test study and the effort to update the docs. I also realised the roles of t0pdfset and theoryid in the n3fit runcard are not documented.