Skip to content

Catalog Builder v2026#144

Draft
Ciheim wants to merge 7 commits intomainfrom
v2026
Draft

Catalog Builder v2026#144
Ciheim wants to merge 7 commits intomainfrom
v2026

Conversation

@Ciheim
Copy link
Contributor

@Ciheim Ciheim commented Feb 19, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions automation for catalogbuilder by adding linting to the existing test workflow, introducing an automated semantic-release workflow for versioning/tagging, and wiring conda publishing to run after releases.

Changes:

  • Add a pylint step to the existing pip-install + pytest CI workflow.
  • Add a new “Semantic Release” workflow to version/tag (and push) on main.
  • Change conda publishing to trigger off completion of the “Semantic Release” workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
.github/workflows/test-pip-install-run-pytest.yml Adds pylint execution to CI runs.
.github/workflows/semantic-release.yml New workflow to run python-semantic-release and push tags/commits.
.github/workflows/publish-conda.yml Switches conda publish trigger to run after “Semantic Release”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


jobs:
semantic-release:
runs-on: ubuntu-latest
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow pushes commits/tags back to the repo, but no explicit permissions are set. To avoid failures when the repo default token permissions are read-only, set workflow/job permissions (e.g., contents: write) appropriate for pushing tags/commits.

Suggested change
runs-on: ubuntu-latest
runs-on: ubuntu-latest
permissions:
contents: write

Copilot uses AI. Check for mistakes.
Comment on lines +32 to +33
semantic-release version
semantic-release changelog
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo search shows no tool.semantic_release configuration (and no __version__ variable); the only version source appears to be pyproject.toml’s [project].version. As written, semantic-release version is likely to fail or be unable to bump the package version—add a semantic-release config (e.g., pointing at pyproject.toml:project.version and defining the commit parser/changelog settings) so the workflow can run deterministically.

Copilot uses AI. Check for mistakes.
semantic-release version
semantic-release changelog
semantic-release tag
git push --follow-tags
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job does a git push to main, which will trigger the same workflow again (since it runs on push to main). Add a guard to prevent redundant/self-triggered runs (e.g., skip when github.actor is github-actions[bot], or configure semantic-release to include [skip ci] in its release commit message).

Copilot uses AI. Check for mistakes.
Comment on lines +4 to +7
workflow_run:
workflows: ["Semantic Release"]
types:
- completed
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_run with types: [completed] will run this publish job even when the Semantic Release workflow fails or is cancelled. Add a success gate (e.g., job-level if: github.event.workflow_run.conclusion == 'success') so conda publishing only happens after a successful release run.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants