Skip to content

Catalog Builder v2026 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Ciheim wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Catalog Builder v2026 #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
466bb3e
semantic release workflow
Feb 14, 2026
93f3bc7
pylint
Feb 14, 2026
88b6bd3
set pylint to always pass
Feb 25, 2026
41f5e44
changling pylint to exit zero
Feb 25, 2026
2a283bc
Update .github/workflows/semantic-release.yml
Ciheim Feb 25, 2026
967d169
fixing logger import
Feb 26, 2026
5f4d6ec
Merge branch 'v2026' of github.com:NOAA-GFDL/CatalogBuilder into v2026
Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/publish-conda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
name: publish_conda

on:
push:
branches:
# only upload upon MR acceptance.
- main
workflow_run:
workflows: ["Semantic Release"]
types:
- completed
Comment on lines +4 to +7
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_run with types: [completed] will run this publish job even when the Semantic Release workflow fails or is cancelled. Add a success gate (e.g., job-level if: github.event.workflow_run.conclusion == 'success') so conda publishing only happens after a successful release run.

Copilot uses AI. Check for mistakes.

jobs:
publish:
runs-on: ubuntu-latest
Expand Down
38 changes: 38 additions & 0 deletions .github/workflows/semantic-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Semantic Release

on:
push:
branches:
- main

jobs:
semantic-release:
runs-on: ubuntu-latest
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow pushes commits/tags back to the repo, but no explicit permissions are set. To avoid failures when the repo default token permissions are read-only, set workflow/job permissions (e.g., contents: write) appropriate for pushing tags/commits.

Suggested change
runs-on: ubuntu-latest
runs-on: ubuntu-latest
permissions:
contents: write

Copilot uses AI. Check for mistakes.
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0
fetch-tags: true

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.11'

- name: Install python-semantic-release
run: pip install python-semantic-release

- name: Configure git user
run: |
git config --global user.name "github-actions[bot]"
git config --global user.email "github-actions[bot]@users.noreply.github.com"

- name: Run semantic-release version, changelog, and tag
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
semantic-release version
semantic-release changelog
Comment on lines +35 to +36
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo search shows no tool.semantic_release configuration (and no __version__ variable); the only version source appears to be pyproject.toml’s [project].version. As written, semantic-release version is likely to fail or be unable to bump the package version—add a semantic-release config (e.g., pointing at pyproject.toml:project.version and defining the commit parser/changelog settings) so the workflow can run deterministically.

Copilot uses AI. Check for mistakes.
semantic-release tag
git push --follow-tags
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job does a git push to main, which will trigger the same workflow again (since it runs on push to main). Add a guard to prevent redundant/self-triggered runs (e.g., skip when github.actor is github-actions[bot], or configure semantic-release to include [skip ci] in its release commit message).

Copilot uses AI. Check for mistakes.
5 changes: 5 additions & 0 deletions .github/workflows/test-pip-install-run-pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ jobs:
run: |
pip install .

- name: Install and use pylint
run: |
pip install pylint
pylint catalogbuilder --exit-zero

- name: Make sample data
run: |
which python
Expand Down
4 changes: 2 additions & 2 deletions catalogbuilder/intakebuilder/localcrawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
import os
from . import getinfo
import re
import logger
logger = logging.getLogger(
import logging
logger = logging.getLogger(__name__)

def crawlLocal(projectdir, dictFilter):
'''
Expand Down