Skip to content

Don't force constraints.txt when running pace tests in external repositories#109

Merged
fmalatino merged 3 commits intoNOAA-GFDL:developfrom
romanc:romanc/dependency-update
Mar 24, 2025
Merged

Don't force constraints.txt when running pace tests in external repositories#109
fmalatino merged 3 commits intoNOAA-GFDL:developfrom
romanc:romanc/dependency-update

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Mar 24, 2025

Description

NDSL runs pace tests as part of NDSL's CI. These tests currently fail on a PR1 because we are bringing in an updated version of gt4py with dependencies that aren't compatible with constraints.txt. This will always happen if NDSL updates a dependency. In previous cases, e.g. PR #103, people manually updated constraints.txt in NOAA-GFDL/pace before being able to merge in NOAA-GFDL/NDSL. Since NDSL is a (downstream) dependency of pace, this is the wrong way round.

The proposed solution here is to ignore the constrains.txt when running as part of the NDSL pipelines. This makes sense since then downstream dependencies can update their dependencies without pace having to do so until pace actually updates NDSL (in which case constrains.txt should be regenerated). This run shows that the PR can be unblocked by the proposed changes.

I had to restrict zarr < 3.0.0 in requirements_dev.txt because it has (as expected for a major version release), breaking API changes, which will make our tests fail.

Blocked PR: NOAA-GFDL/NDSL#119

How Has This Been Tested?

All good as long as GitHub workflows still run.

Checklist:

  • My code follows the style guidelines of this project: N/A
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings: N/A
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

Footnotes

  1. https://github.com/NOAA-GFDL/NDSL/actions/runs/13996303550/job/39192221212?pr=119

@romanc romanc marked this pull request as draft March 24, 2025 08:22
@romanc

This comment was marked as outdated.

@romanc romanc force-pushed the romanc/dependency-update branch from b916b45 to c06a4fe Compare March 24, 2025 09:55
@romanc romanc changed the title Dependency update in preparation for NDSL changes Don't force constraints.txt when running pace tests in external repositories Mar 24, 2025
@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented Mar 24, 2025

@fmalatino @twicki @FlorianDeconinck can't add reviewers due to lacking permissions. Please have a look. Thanks!

Copy link
Copy Markdown
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly we should have done something like this a long time ago

List format (alphabetical order): Surname, Name. Employer/Affiliation

* Abbott, Tristan. GFDL.
* Cattaneo, Roman. NASA.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!

@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented Mar 24, 2025

Just a reminder: I don't have permission to merge in this repo. Feel free to merge whenever you feel like.

@fmalatino fmalatino merged commit 6c0ed5a into NOAA-GFDL:develop Mar 24, 2025
2 checks passed
@romanc romanc deleted the romanc/dependency-update branch March 24, 2025 16:49
@romanc romanc mentioned this pull request Apr 30, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants