Don't force constraints.txt when running pace tests in external repositories#109
Merged
fmalatino merged 3 commits intoNOAA-GFDL:developfrom Mar 24, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
zarr v3 comes with breaking API changes that will fail tests.
b916b45 to
c06a4fe
Compare
constraints.txt when running pace tests in external repositories
Collaborator
Author
|
@fmalatino @twicki @FlorianDeconinck can't add reviewers due to lacking permissions. Please have a look. Thanks! |
7 tasks
fmalatino
approved these changes
Mar 24, 2025
oelbert
approved these changes
Mar 24, 2025
Collaborator
oelbert
left a comment
There was a problem hiding this comment.
Honestly we should have done something like this a long time ago
| List format (alphabetical order): Surname, Name. Employer/Affiliation | ||
|
|
||
| * Abbott, Tristan. GFDL. | ||
| * Cattaneo, Roman. NASA. |
Collaborator
Author
|
Just a reminder: I don't have permission to merge in this repo. Feel free to merge whenever you feel like. |
mlee03
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NDSL runs pace tests as part of NDSL's CI. These tests currently fail on a PR1 because we are bringing in an updated version of gt4py with dependencies that aren't compatible with
constraints.txt. This will always happen if NDSL updates a dependency. In previous cases, e.g. PR #103, people manually updatedconstraints.txtinNOAA-GFDL/pacebefore being able to merge inNOAA-GFDL/NDSL. Since NDSL is a (downstream) dependency ofpace, this is the wrong way round.The proposed solution here is to ignore the
constrains.txtwhen running as part of theNDSLpipelines. This makes sense since then downstream dependencies can update their dependencies withoutpacehaving to do so untilpaceactually updatesNDSL(in which caseconstrains.txtshould be regenerated). This run shows that the PR can be unblocked by the proposed changes.I had to restrict
zarr < 3.0.0inrequirements_dev.txtbecause it has (as expected for a major version release), breaking API changes, which will make our tests fail.Blocked PR: NOAA-GFDL/NDSL#119
How Has This Been Tested?
All good as long as GitHub workflows still run.
Checklist:
Footnotes
https://github.com/NOAA-GFDL/NDSL/actions/runs/13996303550/job/39192221212?pr=119 ↩