Skip to content

Don't force constraints.txt when running pace tests in external repositories #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmalatino merged 3 commits into from
Mar 24, 2025
Merged

Don't force constraints.txt when running pace tests in external repositories #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11246fe
Don't use constraints.txt in NDSL pipeline
romanc Mar 24, 2025
6e7f251
Avoid installing zarr v3
romanc Mar 24, 2025
c06a4fe
Updated list of contributors
romanc Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/main_unit_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
container:
image: ghcr.io/noaa-gfdl/miniforge:mpich
steps:
- name: external trigger Checkout pace/develop
- name: "External trigger: Checkout pace/develop"
if: ${{ inputs.component_trigger }}
uses: actions/checkout@v4
with:
Expand All @@ -32,7 +32,7 @@ jobs:
path: pace
ref: develop

- name: external trigger Remove existing component in pace/develop
- name: "External trigger: Remove existing component in pace/develop"
if: ${{ inputs.component_trigger }}
run: rm -rf ${GITHUB_WORKSPACE}/pace/${{inputs.component_name}}

Expand All @@ -43,11 +43,21 @@ jobs:
path: pace/${{inputs.component_name}}

- name: install packages
if: ${{ ! inputs.component_trigger }}
run: |
cd ${GITHUB_WORKSPACE}/pace
pip3 install --upgrade pip setuptools wheel
pip3 install -r requirements_dev.txt -c constraints.txt

- name: "External trigger: Install packages"
if: ${{ inputs.component_trigger }}
# Ignore `constraints.txt` when running as part of the NDSL pipeline
# to avoid false positives in package dependency resolution.
run: |
cd ${GITHUB_WORKSPACE}/pace
pip3 install --upgrade pip setuptools wheel
pip3 install -r requirements_dev.txt

- name: prepare input files
run: |
cd ${GITHUB_WORKSPACE}/pace
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
List format (alphabetical order): Surname, Name. Employer/Affiliation

* Abbott, Tristan. GFDL.
* Cattaneo, Roman. NASA.
Copy link
Copy Markdown
Collaborator

@oelbert oelbert Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!

* Cheeseman, Mark. Vulcan Inc.
* Dahm, Johann. Allen Institute for AI.
* Davis, Eddie. Allen Institute for AI.
Expand Down
2 changes: 1 addition & 1 deletion requirements_dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ scipy
nbmake
mpi4py
xarray
zarr
zarr <3.0.0
dask
netCDF4
cftime
Expand Down