Remove use of deprecated start_index from Categorify#1134
Merged
nv-alaiacano merged 4 commits intoNVIDIA-Merlin:mainfrom Jun 6, 2023
Merged
Remove use of deprecated start_index from Categorify#1134nv-alaiacano merged 4 commits intoNVIDIA-Merlin:mainfrom
nv-alaiacano merged 4 commits intoNVIDIA-Merlin:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation preview |
rnyak
reviewed
Jun 5, 2023
| "source": [ | ||
| "%%time\n", | ||
| "item_features_names = ['f_' + str(col) for col in [47, 68]]\n", | ||
| "cat_features = [['item_id', 'purchase_id']] + item_features_names >> nvt.ops.Categorify(start_index=1)\n", |
Contributor
There was a problem hiding this comment.
May be we can add a note for the user something like that:
Categorify op maps nulls to `1`, OOVs to `2` and the frequent categories are encoded starting from `3`. Please note that we reserve `0` for padding value.
Contributor
There was a problem hiding this comment.
can I propose merging this fix to get things working then you can update the copy?
rnyak
approved these changes
Jun 5, 2023
Contributor
Author
|
This is the error that is printed out in |
nv-alaiacano
approved these changes
Jun 5, 2023
This was referenced Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Fix use of Categorify to support new version of NVTabular
Implementation Details 🚧
start_indexwas removed fromCategorifyin Refactor Categorify NVTabular#1692