chore: initial telemetry impl #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the DCO ✍️ ✅ |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
nabinchha
reviewed
Dec 10, 2025
src/data_designer/engine/dataset_builders/column_wise_builder.py
Outdated
Show resolved
Hide resolved
Contributor
for this, I'd recommend excluding |
johnnygreco
reviewed
Dec 15, 2025
src/data_designer/engine/dataset_builders/column_wise_builder.py
Outdated
Show resolved
Hide resolved
kirit93
reviewed
Dec 16, 2025
nabinchha
previously approved these changes
Dec 17, 2025
Contributor
nabinchha
left a comment
nabinchha
left a comment
There was a problem hiding this comment.
Nice, thanks @johntmyers!
src/data_designer/engine/dataset_builders/column_wise_builder.py
Outdated
Show resolved
Hide resolved
johnnygreco
previously approved these changes
Dec 17, 2025
Contributor
johnnygreco
left a comment
johnnygreco
left a comment
There was a problem hiding this comment.
thanks @johntmyers 🙌
Co-authored-by: Nabin Mulepati <[email protected]>
johntmyers
dismissed stale reviews from johnnygreco and nabinchha
via
f6678c5
nabinchha
previously approved these changes
Dec 17, 2025
…ataDesigner into johntmyers/chore/telemetry
johnnygreco
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds anonymous model usage telemetry collection. Notable changes:
We generate an
InferenceEventwhich tracks model and token counts after each DD batch is created. This provides higher fidelity during longer running jobs. In order to do this we need to snapshot the current token usage from the cumulative counts in the model registry.The telemetry module is currently being vendored in. It's fully tested from its source which we can discuss offline if need be. It's a best-effort approach to reduce risk of interfering with any actual library usage.