Skip to content

docs: add documentation on how to configure custom model settings #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nabinchha merged 55 commits into from
Dec 15, 2025
Merged

docs: add documentation on how to configure custom model settings #124

nabinchha merged 55 commits into from
Dec 15, 2025

Conversation

@nabinchha
Copy link
Contributor

@nabinchha nabinchha commented Dec 11, 2025 •
edited
Loading

closes: #123
will help addresss: #113

This PR needs to merge first.

@nabinchha
Add generation type to ModelConfig
dc041f7
@nabinchha
pass tests
0d6b830
@nabinchha
added generate_text_embeddings
254fd8a
@nabinchha
tests
1126ea1
@nabinchha
remove sensitive=True old artifact no longer needed
744bc8f
@nabinchha
Slight refactor
b913f8d
@nabinchha
slight refactor
052db7a
@nabinchha
Added embedding generator
5504c8d
@nabinchha
chunk_separator -> chunk_pattern
4b6f877
@nabinchha
update tests
04fc0f3
@nabinchha
rename for consistency
26d6da1
@nabinchha
Restructure InferenceParameters -> CompletionInferenceParameters, Bas…
6facbd2 
…eInferenceParameters, EmbeddingInferenceParameters
@nabinchha
Remove purpose from consolidated kwargs
2c1b267
@nabinchha
WithModelConfiguration.inference_parameters should should be typed wi…
4b1492b 
…th BaseInferenceParameters
@nabinchha
Type as WithModelGeneration
c445caf
@nabinchha
Add image generation modality
4b8aa2b
@nabinchha
update return type for generate_kwargs
2c5933f
@nabinchha
make generation_type a field of ModelConfig as opposed to a prop reso…
c6c29d4 
…lved based on the type of InferenceParameters
@nabinchha
remove regex based chunking from embedding generator
06a724b
@nabinchha
Merge branch 'main' into nmulepati/feat/support-embedding-generation
bbb6a83
@nabinchha
Remove image generation for now
b9455d4
@nabinchha
more tests and updates
e5c0b7a
@nabinchha
column_type_is_llm_generated -> column_type_is_model_generated
6460c6b
@nabinchha
change set to list: fix flaky tests
e294b40
@nabinchha
CompletionInferenceParameters -> ChatCompletionInferenceParameters fo…
4e697ec 
…r consistency with generation_type
@nabinchha
Update docs
d650398
@nabinchha
fix deprecation warning originating from cli model settings
4601e3f
@nabinchha
update display of inference parameters in cli list
65ba5bf
@nabinchha
save prog on inference parameter
0917d6e
@nabinchha
updates for the ocnfig builder
1aa74dd
@nabinchha nabinchha changed the base branch from main to nmulepati/feat/support-embedding-generation December 11, 2025 18:09
@nabinchha
Copy link
Contributor Author

nabinchha commented Dec 11, 2025

recheck

johnnygreco
johnnygreco reviewed Dec 15, 2025
View reviewed changes
johnnygreco
johnnygreco reviewed Dec 15, 2025
View reviewed changes
johnnygreco
johnnygreco reviewed Dec 15, 2025
View reviewed changes
johnnygreco
johnnygreco reviewed Dec 15, 2025
View reviewed changes
johnnygreco
johnnygreco reviewed Dec 15, 2025
View reviewed changes
Copy link
Contributor

@johnnygreco johnnygreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nabinchha!

I feel like we are missing a very clear, concise (and punchy) intro to the model documentation. The first thing you see when you open the Concepts section is "Default Model Settings". I'm wondering about a structure that looks more like

Models
- Overview: This would have a punchy in intro that says DD is model agnostic, letting you a Bring Your Own (BYO) model endpoints, and we provide defaults so you can get started quickly out of the box. We could also add Model Providers, Model Configs, and Inference Parameters as subsections to this section.
- Default Mdel Settings
- BYO Model Providers
- Configure with the CLI

@nabinchha
Copy link
Contributor Author

nabinchha commented Dec 15, 2025

Thanks, @nabinchha!

I feel like we are missing a very clear, concise (and punchy) intro to the model documentation. The first thing you see when you open the Concepts section is "Default Model Settings". I'm wondering about a structure that looks more like

Models - Overview: This would have a punchy in intro that says DD is model agnostic, letting you a Bring Your Own (BYO) model endpoints, and we provide defaults so you can get started quickly out of the box. We could also add Model Providers, Model Configs, and Inference Parameters as subsections to this section. - Default Mdel Settings - BYO Model Providers - Configure with the CLI

Yes, I agree. Let me think about that and open a new PR with overview and updates to tie them all together.

johnnygreco
johnnygreco previously approved these changes Dec 15, 2025
View reviewed changes
@nabinchha nabinchha mentioned this pull request Dec 15, 2025
Merged
Base automatically changed from nmulepati/feat/support-embedding-generation to main December 15, 2025 18:03
@nabinchha nabinchha dismissed johnnygreco’s stale review December 15, 2025 18:03

The base branch was changed.

@nabinchha nabinchha merged commit 3065179 into main Dec 15, 2025
13 checks passed
@nabinchha nabinchha deleted the nmulepati/docs/123-docs-for-custom-model-settings branch December 15, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnnygreco johnnygreco johnnygreco approved these changes

@andreatgretel andreatgretel Awaiting requested review from andreatgretel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add docs for custom model settings

3 participants

@nabinchha @johnnygreco