Skip to content

fix: handling of different inference params in info display #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nabinchha merged 1 commit into from
Dec 16, 2025
Merged

fix: handling of different inference params in info display #141

nabinchha merged 1 commit into from
Dec 16, 2025

Conversation

@nabinchha
Copy link
Contributor

@nabinchha nabinchha commented Dec 16, 2025

closes #140

After fix:
Screenshot 2025-12-16 at 10 13 42 AM

Screenshot 2025-12-16 at 10 13 58 AM

@nabinchha nabinchha changed the title fix: handle of different inference params in info display fix: handling of different inference params in info display Dec 16, 2025
@nabinchha
Copy link
Contributor Author

nabinchha commented Dec 16, 2025

Should we change Model ID -> Model or vice versa to stay consistent across the two tables?

johnnygreco
johnnygreco approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@johnnygreco johnnygreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet 🙌

@nabinchha nabinchha merged commit 796e370 into main Dec 16, 2025
15 checks passed
@nabinchha nabinchha deleted the nmulepati/fix-140-handle-inference-params-info-display branch December 16, 2025 18:12
@johnnygreco
Copy link
Contributor

johnnygreco commented Dec 16, 2025

Should we change Model ID -> Model or vice versa to stay consistent across the two tables?

lol just noticed this. probably should switch to model for consistency. i can update in my current PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnnygreco johnnygreco johnnygreco approved these changes

@andreatgretel andreatgretel Awaiting requested review from andreatgretel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle different inference params in config builder info display

3 participants

@nabinchha @johnnygreco