-
Notifications
You must be signed in to change notification settings - Fork 51
refactor: plugin system updates #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cff93d3
plugin system updates
mikeknep 5f7c21a
Modify test helper to make assert statements
mikeknep f0fe161
Rename stubs module
mikeknep 3c32d31
Plugin field descriptions
mikeknep 6fe4011
Add ast parsing for more validation
mikeknep 3b1e96c
Rename fields to _qualified_name
mikeknep bee17c3
Remove tmp notes
mikeknep 54206bf
Update plugin example
mikeknep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from data_designer.plugins.testing.utils import assert_valid_plugin | ||
|
|
||
| __all__ = [ | ||
| assert_valid_plugin.__name__, | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from typing import Literal | ||
|
|
||
| from data_designer.config.base import ConfigBase | ||
| from data_designer.config.column_configs import SingleColumnConfig | ||
| from data_designer.engine.configurable_task import ConfigurableTask, ConfigurableTaskMetadata | ||
|
|
||
| MODULE_NAME = __name__ | ||
|
|
||
|
|
||
| class ValidTestConfig(SingleColumnConfig): | ||
| """Valid config for testing plugin creation.""" | ||
|
|
||
| column_type: Literal["test-generator"] = "test-generator" | ||
| name: str | ||
|
|
||
|
|
||
| class ValidTestTask(ConfigurableTask[ValidTestConfig]): | ||
| """Valid task for testing plugin creation.""" | ||
|
|
||
| @staticmethod | ||
| def metadata() -> ConfigurableTaskMetadata: | ||
| return ConfigurableTaskMetadata( | ||
| name="test_generator", | ||
| description="Test generator", | ||
| required_resources=None, | ||
| ) | ||
|
|
||
|
|
||
| class ConfigWithoutDiscriminator(ConfigBase): | ||
| some_field: str | ||
|
|
||
|
|
||
| class ConfigWithStringField(ConfigBase): | ||
| column_type: str = "test-generator" | ||
|
|
||
|
|
||
| class ConfigWithNonStringDefault(ConfigBase): | ||
| column_type: Literal["test-generator"] = 123 # type: ignore | ||
|
|
||
|
|
||
| class ConfigWithInvalidKey(ConfigBase): | ||
| column_type: Literal["invalid-key-!@#"] = "invalid-key-!@#" | ||
|
|
||
|
|
||
| class StubPluginConfigA(SingleColumnConfig): | ||
| column_type: Literal["test-plugin-a"] = "test-plugin-a" | ||
|
|
||
|
|
||
| class StubPluginConfigB(SingleColumnConfig): | ||
| column_type: Literal["test-plugin-b"] = "test-plugin-b" | ||
|
|
||
|
|
||
| class StubPluginTaskA(ConfigurableTask[StubPluginConfigA]): | ||
| @staticmethod | ||
| def metadata() -> ConfigurableTaskMetadata: | ||
| return ConfigurableTaskMetadata( | ||
| name="test_plugin_a", | ||
| description="Test plugin A", | ||
| required_resources=None, | ||
| ) | ||
|
|
||
|
|
||
| class StubPluginTaskB(ConfigurableTask[StubPluginConfigB]): | ||
| @staticmethod | ||
| def metadata() -> ConfigurableTaskMetadata: | ||
| return ConfigurableTaskMetadata( | ||
| name="test_plugin_b", | ||
| description="Test plugin B", | ||
| required_resources=None, | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from data_designer.config.base import ConfigBase | ||
| from data_designer.engine.configurable_task import ConfigurableTask | ||
| from data_designer.plugins.plugin import Plugin | ||
|
|
||
|
|
||
| def assert_valid_plugin(plugin: Plugin) -> None: | ||
| assert issubclass(plugin.config_cls, ConfigBase), "Plugin config class is not a subclass of ConfigBase" | ||
| assert issubclass(plugin.task_cls, ConfigurableTask), "Plugin task class is not a subclass of ConfigurableTask" | ||
mikeknep marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.