fix: update get_file_column_names to take a file reference #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnygreco
commented
Nov 24, 2025
| return fetch_seed_dataset_column_names_from_local_file(seed_dataset_reference.dataset) | ||
|
|
||
|
|
||
| def fetch_seed_dataset_column_names_from_datastore( |
Contributor
Author
There was a problem hiding this comment.
made these public because we should use them directly for testsing
nabinchha
approved these changes
Nov 24, 2025
| with fs.open(f"datasets/{repo_id}/{filename}") as f: | ||
| return get_file_column_names(f, file_type) | ||
|
|
||
| def _extract_single_file_path_from_glob_pattern_if_present( |
Contributor
There was a problem hiding this comment.
This could be public too so we can more easily and directly test code paths?
nabinchha
deleted the
johnny/fix/bug-when-getting-column-names-from-datastore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.