Skip to content

Conversation

@andreatgretel
Copy link
Contributor

This PR:

  1. removes the docs/notebooks folder, and adds docs/notebook_source; files inside this folder are not .ipynb but .py. The docs/notebooks folder can be recreated (exactly the same as before) by running make convert-execute-notebooks, which relies on jupytext to convert/run the notebooks (this was mostly done by @johnnygreco). NB, API keys must be set in order for this command to succeed (should we maybe add a check on the Makefile?)
  2. adds a .github/workflows/build-notebooks.yml workflow that runs this make command on the CI, using an API key from Secrets (secrets.NVIDIA_API_KEY, created in my Build account, expires in 12 months)
  3. modifies the build-docs.yml and pack-tutorials.yml workflows, which need to call build-notebooks.yml first in order to work (a modified version of build-docs has been tested here)
  4. small cleanups on existing workflows - standardized names, added more details for steps

Copy link
Contributor

@johnnygreco johnnygreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @andreatgretel, thank you 🙏

Copy link
Contributor

@nabinchha nabinchha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Thanks @andreatgretel!

@andreatgretel andreatgretel merged commit 5d4ad10 into main Dec 3, 2025
13 checks passed
@andreatgretel andreatgretel deleted the andreatgretel/moving-notebooks-to-jupytext branch December 4, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants