-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Update README to reflect current Repo Status #15217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nithinraok <[email protected]>
README.md
Outdated
| --ulimit memlock=-1 \ | ||
| --ulimit stack=67108864 \ | ||
| nvcr.io/nvidia/pytorch:${NV_PYTORCH_TAG:-'nvcr.io/nvidia/pytorch:25.01-py3'} | ||
| ${NV_PYTORCH_TAG:-'nvcr.io/nvidia/pytorch:25.11-py3'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're working on validating that pytorch 25.11 works for the container. The current CI uses pytorch 25.09. Maybe should just do pytorch 25.09 for now?
Signed-off-by: nithinraok <[email protected]>
README.md
Outdated
|
|
||
| We recommended that you start with a base NVIDIA PyTorch container: | ||
| nvcr.io/nvidia/pytorch:25.01-py3. | ||
| nvcr.io/nvidia/pytorch:25.11-py3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this to 25.09.
README.md
Outdated
| ### NGC PyTorch container | ||
|
|
||
| **NOTE: The following steps are supported beginning with 24.04 (NeMo-Toolkit 2.3.0)** | ||
| **NOTE: The following steps are supported beginning with 25.11 (NeMo-Toolkit 2.6.0)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to update this to 25.09 as well.
Signed-off-by: nithinraok <[email protected]>
|
Merging as there are no tests for README |
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Update readme to reflect current repo status.
Collection: [all]
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information