Skip to content

Conversation

@nithinraok
Copy link
Member

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Update readme to reflect current repo status.

Collection: [all]

Changelog

  • Update READMe

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

README.md Outdated
--ulimit memlock=-1 \
--ulimit stack=67108864 \
nvcr.io/nvidia/pytorch:${NV_PYTORCH_TAG:-'nvcr.io/nvidia/pytorch:25.01-py3'}
${NV_PYTORCH_TAG:-'nvcr.io/nvidia/pytorch:25.11-py3'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're working on validating that pytorch 25.11 works for the container. The current CI uses pytorch 25.09. Maybe should just do pytorch 25.09 for now?

Signed-off-by: nithinraok <[email protected]>
README.md Outdated

We recommended that you start with a base NVIDIA PyTorch container:
nvcr.io/nvidia/pytorch:25.01-py3.
nvcr.io/nvidia/pytorch:25.11-py3.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to 25.09.

README.md Outdated
### NGC PyTorch container

**NOTE: The following steps are supported beginning with 24.04 (NeMo-Toolkit 2.3.0)**
**NOTE: The following steps are supported beginning with 25.11 (NeMo-Toolkit 2.6.0)**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to update this to 25.09 as well.

Signed-off-by: nithinraok <[email protected]>
@nithinraok nithinraok enabled auto-merge (squash) January 7, 2026 16:43
@nithinraok nithinraok disabled auto-merge January 7, 2026 16:44
@nithinraok
Copy link
Member Author

Merging as there are no tests for README

@nithinraok nithinraok merged commit 0042f34 into main Jan 7, 2026
38 checks passed
@nithinraok nithinraok deleted the update_readme branch January 7, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants