Conversation
rwiltz
commented
Dec 11, 2025
Contributor
Author
|
Some of the utility classes make more sense being in some common directory, but I will refactor that in a follow up MR |
Contributor
Author
|
Also probably good to include a mock for the functions that rely on ManusSDK so the code can still build/test can be run. I'll add that in a follow up as well |
aristarkhovNV
requested changes
Dec 11, 2025
jiwenc-nv
reviewed
Dec 12, 2025
| @@ -0,0 +1,124 @@ | |||
| // Copyright 2025, NVIDIA CORPORATION. | |||
| // SPDX-License-Identifier: Apache-2.0 or MIT | |||
Collaborator
There was a problem hiding this comment.
is it intentional to have dual license here? @nvddr ?
60cc4ce to
6354223
Compare
|
|
||
| # Include directories | ||
| target_include_directories(teleop_plugin_utils | ||
| PUBLIC |
Collaborator
There was a problem hiding this comment.
Suggested change
| PUBLIC | |
| INTERFACE |
jiwenc-nv
approved these changes
Dec 17, 2025
99612c1 to
877b57d
Compare
aristarkhovNV
approved these changes
Dec 18, 2025
The manus plugin uses the Manus SDK to query glove data, and polls the OpenXR for controller pose. It then uses an offset aim pose as the wrist joint pose, and uses that as the root for all the subsequent joint poses from Manus. Then it pushes this back to the CloudXR runtime.
877b57d to
477974b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manus plugin uses the Manus SDK to query glove data, and polls the OpenXR for controller pose. It then uses an offset aim pose as the wrist joint pose, and uses that as the root for all the subsequent joint poses from Manus. Then it pushes this back to the CloudXR runtime.