Add pre commit to verify test status#841
Merged
pstjohn merged 2 commits intoNVIDIA:mainfrom Apr 22, 2025
Merged
Conversation
pstjohn
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
ohadmo and
trvachov
as code owners
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
force-pushed
the
pstjohn/add-pre-commit-to-verify-test-status
branch
from
cc52a8a to
a79b43c
Compare
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
trvachov
approved these changes
Apr 22, 2025
jomitchellnv
approved these changes
Apr 22, 2025
cspades
pushed a commit
that referenced
this pull request
May 4, 2025
Previously if pre-commit failed, it would cause `run-tests` to be skipped, which would then mean that `verify-tests-status` would give the PR the green light. That's obviously a problem, so we need to make sure all these tests are added to the verify-tests-status check. Ideally we could put some more logic in that if block to check if we're in a merge queue, whether tests were intentionally skipped, etc. --------- Signed-off-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: Cory Ye <cye@nvidia.com>
farhadrgh
pushed a commit
that referenced
this pull request
May 5, 2025
Previously if pre-commit failed, it would cause `run-tests` to be skipped, which would then mean that `verify-tests-status` would give the PR the green light. That's obviously a problem, so we need to make sure all these tests are added to the verify-tests-status check. Ideally we could put some more logic in that if block to check if we're in a merge queue, whether tests were intentionally skipped, etc. --------- Signed-off-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: Farhad Ramezanghorbani <farhadr@nvidia.com>
camirr-nv
pushed a commit
that referenced
this pull request
Jun 26, 2025
Previously if pre-commit failed, it would cause `run-tests` to be skipped, which would then mean that `verify-tests-status` would give the PR the green light. That's obviously a problem, so we need to make sure all these tests are added to the verify-tests-status check. Ideally we could put some more logic in that if block to check if we're in a merge queue, whether tests were intentionally skipped, etc. --------- Signed-off-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: Ubuntu <camirr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if pre-commit failed, it would cause
run-teststo be skipped, which would then mean thatverify-tests-statuswould give the PR the green light. That's obviously a problem, so we need to make sure all these tests are added to the verify-tests-status check. Ideally we could put some more logic in that if block to check if we're in a merge queue, whether tests were intentionally skipped, etc.