Skip to content

Add pre commit to verify test status #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pstjohn merged 2 commits into from
Apr 22, 2025
Merged

Add pre commit to verify test status #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a79b43c
ensure pre-commit and docker builds pass in tests
pstjohn Apr 22, 2025
2571e81
fix formatting
pstjohn Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,9 @@ jobs:
# This steps checks the status of all test jobs and fails if any of them failed or were cancelled.
# It is a workaround for the lack of a built-in feature to finalize a pipeline by checking the status of multiple jobs
needs: # List all your run-*-test jobs
- pre-commit
- get-pr-labels
- build-bionemo-image
- run-tests
- run-slow-tests
- run-notebooks-docs
Expand Down
4 changes: 2 additions & 2 deletions docs/docs/models/geneformer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,11 @@ NVIDIA believes Trustworthy AI is a shared responsibility and we have establishe

### geneformer-10M
<!-- WandB Logs: https://wandb.ai/clara-discovery/Geneformer-pretraining-jsjconfigs/runs/i8LWOctg?nw=nwuserjomitchell -->
Training was performed on 8 servers with 8 A100 GPUs each for a total of 81485 steps using the CELLxGENE split with a per-gpu micro batch size 32 and global batch size of 2048. Training took a total of 4 days, 8 hours of wallclock time. As can be seen in the following images, training and validation curves both decreased fairly smoothly throughout the course of training.
Training was performed on 8 servers with 8 A100 GPUs each for a total of 81485 steps using the CELLxGENE split with a per-gpu micro batch size 32 and global batch size of 2048. Training took a total of 4 days, 8 hours of wallclock time. As can be seen in the following images, training and validation curves both decreased fairly smoothly throughout the course of training.

![Training Loss Geneformer 10M](../assets/images/geneformer/geneformer_10m_training_loss.png)
![Validation Loss Geneformer 10M](../assets/images/geneformer/geneformer_10m_val_loss.png)



### geneformer-106M
Expand Down