Skip to content

toolkit: install guide: refer to section about supported platforms, tweak headings #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgehrcke merged 7 commits into from
Feb 19, 2025
Merged

toolkit: install guide: refer to section about supported platforms, tweak headings #158

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8316505
Tweak headings in toolkit install guide
jgehrcke Feb 13, 2025
550b98a
Refer to supported platforms section in toolkit install guide
jgehrcke Feb 13, 2025
c85c37c
review feedback: work on section headings
jgehrcke Feb 13, 2025
3b8d4df
simplify
jgehrcke Feb 13, 2025
06bd2b8
collab with evan: headings, notes
jgehrcke Feb 14, 2025
ad56540
use legacy heading anchors
jgehrcke Feb 14, 2025
cd38c8b
remove todo
jgehrcke Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions container-toolkit/install-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,23 @@

# Installing the NVIDIA Container Toolkit


## Installation

(pre-requisites)=

### Prerequisites

Install the NVIDIA GPU driver for your Linux distribution.
NVIDIA recommends installing the driver by using the package manager for your distribution.
1. Read [this section](./supported-platforms.md) about platform support.

2. Install the NVIDIA GPU driver for your Linux distribution.
NVIDIA recommends installing the driver by using the package manager for your distribution.
For information about installing the driver with a package manager, refer to
the [_NVIDIA Driver Installation Quickstart Guide_](https://docs.nvidia.com/datacenter/tesla/tesla-installation-notes/index.html).
Alternatively, you can install the driver by [downloading](https://www.nvidia.com/en-us/drivers/) a `.run` installer.

Alternatively, you can install the driver by downloading a `.run` installer.
Refer to the NVIDIA [Official Drivers](https://www.nvidia.com/Download/index.aspx?lang=en-us) page.
Copy link
Collaborator

@a-mccarthy a-mccarthy Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we got ride of this link? I dont remember if this has come up before in a previous comments. thanks

Copy link
Contributor Author

@jgehrcke jgehrcke Feb 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No removal. I replaced it with a more modern URL. You will notice in your browser that the old URL redirects to /en-us/drivers.

Personally, I like to look at changes like this in the rendered view.

We should also work towards using a concept often called "semantic line breaks" to keep the markdown source diff better reviewable.


### Installing with Apt
### Ubuntu and Debian
Copy link
Member

@elezar elezar Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this change for ubuntu and debian since I think this covers most users of apt. My concern is that using the same construct for RPM-based distributions where there are other prominent ones that are not listed. (Rocky comes to mind). This will definitely lead to GitHub issues along the lines of "RockyLinux support when?". At present my response is to link the "Installing with Yum or Dnf" section, but I can see more questions being raised if I link a section that's titled "RHEL/CentOS, Fedora, Amazon Linux".

Copy link
Contributor Author

@jgehrcke jgehrcke Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. note: added a commit after working on this with Evan


1. Configure the production repository:

Expand Down Expand Up @@ -53,7 +54,7 @@ Refer to the NVIDIA [Official Drivers](https://www.nvidia.com/Download/index.asp
$ sudo apt-get install -y nvidia-container-toolkit
```

### Installing with Yum or Dnf
### RHEL/CentOS, Fedora, Amazon Linux

1. Configure the production repository:

Expand All @@ -74,7 +75,7 @@ Refer to the NVIDIA [Official Drivers](https://www.nvidia.com/Download/index.asp
$ sudo yum install -y nvidia-container-toolkit
```

### Installing with Zypper
### OpenSUSE, SLE

1. Configure the production repository:

Expand Down