feat(cli): complete CLI with full CRUD operations (#563)

[ArangoGutierrez]

Summary

Implements the complete CLI CRUD operations epic (#563) to unblock 11 dependent PRs. This adds:

• Logger verbosity levels: quiet/normal/verbose/debug with -q, --verbose, -d flags
• Output formatting: table/JSON/YAML support via pkg/output package
• New commands: describe, get kubeconfig, get ssh-config, ssh, scp, update
• Refactored list: renamed --quiet to --ids-only for clarity
• Shared utilities: cmd/cli/common package with GetHostURL and ConnectSSH
• Status command: integrated output formatting with --output flag

Key changes

• internal/logger/logger.go — verbosity levels (Quiet/Normal/Verbose/Debug)
• pkg/output/output.go — Formatter, TablePrinter, TableData interface
• cmd/cli/common/host.go — shared host URL resolution and SSH connection
• cmd/cli/describe/ — detailed instance info with JSON/YAML/table output
• cmd/cli/get/ — kubeconfig download and SSH config generation
• cmd/cli/ssh/ — interactive SSH and remote command execution
• cmd/cli/scp/ — SFTP file transfer with recursive directory support
• cmd/cli/update/ — add components, labels, and re-provision instances

Review fixes included

• C1: Fixed nil map panic when writing labels during --reprovision
• C2: Fixed SSH remote command quoting (replaced broken containsSpace logic)
• I1: Extracted duplicate getHostURL/connectSSH into shared common package
• I2: Use path (POSIX) for remote SFTP paths instead of filepath
• I3: Log warnings for skipped files during recursive remote copy
• I4: Use c.IsSet() for flags with defaults to prevent config overwrites

Test plan

• All existing CLI tests pass (go test ./cmd/cli/...)
• New unit tests for output formatting (pkg/output)
• New unit tests for GetHostURL across ssh, get, and common packages
• New unit tests for parsePath, describe, update, and label handling
• Regression test for nil Labels map panic (C1)
• Manual: holodeck list, holodeck describe <id>, holodeck ssh <id>
• Manual: holodeck scp ./file <id>:/tmp/, holodeck get kubeconfig <id>
• Manual: holodeck update <id> --add-driver --driver-version 560.35.03

Closes #563

[coveralls]

Pull Request Test Coverage Report for Build 21752525231

Details

• 85 of 87 (97.7%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+1.0%) to 45.946%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/output/output.go	85	87	97.7%

Totals
Change from base Build 21708182973:	1.0%
Covered Lines:	2091
Relevant Lines:	4551

---

💛 - Coveralls

[Copilot]

Pull request overview

This PR implements a comprehensive set of CLI CRUD operations to complete the Holodeck CLI (#563), adding essential features for managing GPU-ready cloud environments. The changes introduce global verbosity levels, structured output formatting, and critical SSH/file transfer capabilities.

Changes:

• Added logger verbosity system (Quiet/Normal/Verbose/Debug) with corresponding flags (-q, --verbose, -d)
• Created pkg/output package for consistent JSON/YAML/table formatting across commands
• Implemented six new commands: describe, get (kubeconfig/ssh-config), ssh, scp, and update
• Refactored list command to support output formats and renamed --quiet to --ids-only
• Created shared cmd/cli/common package with GetHostURL and ConnectSSH utilities

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/logger/logger.go	Added verbosity levels (Quiet/Normal/Verbose/Debug) with new Debug() and Trace() methods
internal/logger/logger_test.go	Comprehensive unit tests for verbosity filtering and methods
pkg/output/output.go	Formatter interface with table/JSON/YAML support and TableData interface
pkg/output/output_test.go	732 lines of tests covering all output formats and edge cases
cmd/cli/common/host.go	Shared GetHostURL and ConnectSSH utilities (contains bug)
cmd/cli/describe/describe.go	Detailed instance introspection with multi-format output
cmd/cli/get/get.go	Kubeconfig download and SSH config generation subcommands
cmd/cli/ssh/ssh.go	Interactive SSH and remote command execution
cmd/cli/scp/scp.go	SFTP file transfer with recursive directory support, proper POSIX path handling
cmd/cli/update/update.go	Add components, labels, and re-provision instances (contains bug)
cmd/cli/list/list.go	Refactored with output formatting, renamed --quiet to --ids-only
cmd/cli/status/status.go	Added output formatting with --output flag
cmd/cli/main.go	Integrated global verbosity flags and new commands

[Copilot]

The field path should be env.Spec.Instance.HostUrl not env.Spec.HostUrl. The HostUrl field is defined on the Instance struct, not directly on EnvironmentSpec. This will cause a compilation error or runtime panic.

Suggested change

	return env.Spec.HostUrl, nil
	if env.Spec.Instance != nil {
	return env.Spec.Instance.HostUrl, nil
	}

[Copilot]

The field path should be env.Spec.Instance.HostUrl not env.Spec.HostUrl. The HostUrl field is defined on the Instance struct, not directly on EnvironmentSpec. This will cause a compilation error or runtime panic.

Suggested change

	hostUrl = env.Spec.HostUrl
	if env.Spec.Instance == nil {
	return fmt.Errorf("instance spec is required for SSH provider")
	}
	hostUrl = env.Spec.Instance.HostUrl