Skip to content

Conversation

@SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Dec 11, 2024

See NativePHP/electron#143

  • src/Client/Client.php: PowerMonitor passes parameters to one of its endpoints. Unfortunately, they were not sent by the client.
  • PowerMonitor::class now implements Contracts\PowerMonitor::class interface
  • Facades\PowerMonitor::fake() swaps implementations with a test double concrete
  • Implement PowerMonitorFake::class with assertion helpers
  • Test that PowerMonitorFake::class assertions work

I plan to submit another PR with a fix for phpstan.neon, which is currently not working, and add a GitHub action to check every push.

@SRWieZ SRWieZ marked this pull request as ready for review December 12, 2024 09:22
@SRWieZ
Copy link
Member Author

SRWieZ commented Dec 12, 2024

Ready for review!

@SRWieZ SRWieZ changed the title Fixes and improvement to powerMonitor Fixes and improvements to powerMonitor Dec 12, 2024
@SRWieZ SRWieZ mentioned this pull request Dec 12, 2024
@simonhamp simonhamp merged commit c96a7c5 into NativePHP:main Dec 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants