Skip to content

Conversation

@MistakeNot4892
Copy link
Contributor

Description of changes

Adds a centrifuge to replace the honey extractor. Pulled out of #4266.

Why and what will this PR improve

Less bespoke machinery, more useful/extensible code.

Authorship

Myself.

Changelog

Nothing player-facing beyond the name of the machine, really.

@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. work in progress This PR is under development and shouldn't be merged. and removed ready for review This PR is ready for review and merge. labels Feb 9, 2025
@MistakeNot4892 MistakeNot4892 force-pushed the feature/centrifuge branch 2 times, most recently from 342aa7d to 321765d Compare February 9, 2025 07:24
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed work in progress This PR is under development and shouldn't be merged. labels Feb 9, 2025
@MistakeNot4892 MistakeNot4892 mentioned this pull request Feb 9, 2025
7 tasks
@MistakeNot4892 MistakeNot4892 force-pushed the feature/centrifuge branch 2 times, most recently from d2c63a3 to 205eac2 Compare February 11, 2025 06:12
@MistakeNot4892 MistakeNot4892 added has dependencies This PR should not be merged prior to any PRs linked in body or comments. and removed ready for review This PR is ready for review and merge. labels Feb 11, 2025
@MistakeNot4892
Copy link
Contributor Author

Depends on #4845

@MistakeNot4892 MistakeNot4892 force-pushed the feature/centrifuge branch 4 times, most recently from dbe0f59 to 307a82c Compare February 12, 2025 11:50
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed has dependencies This PR should not be merged prior to any PRs linked in body or comments. labels Feb 13, 2025
thing.dropInto(loc)

/obj/machinery/centrifuge/Initialize()
sound_id = "[work_sound]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we stringifying it here? what's the deal with this anyway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every other usage does it. No idea if it's necessary but it's not exactly hot code.

@out-of-phaze out-of-phaze merged commit c2b31ad into NebulaSS13:dev Feb 16, 2025
13 checks passed
@MistakeNot4892 MistakeNot4892 deleted the feature/centrifuge branch February 25, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This PR is ready for review and merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants