fix: corregir comando docker login en deploy workflow #107
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a syntax error in the GitHub Actions deployment workflow by correcting a malformed docker login command that was split across multiple lines with incorrect backslash usage. The fix consolidates the command structure to properly authenticate with GitHub Container Registry (GHCR).
Key Changes:
- Fixed malformed multi-line docker login command syntax
- Consolidated three broken command lines into two functional docker login commands
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin | ||
There was a problem hiding this comment.
There are two docker login commands executing sequentially, which is redundant. The second login (line 24) will overwrite the authentication from the first login (line 23). Only one docker login command should be used.
Additionally, line 24 has an inconsistency: the variable ${{ github.actor }} is not quoted, unlike line 23 where it's properly quoted as "${{ github.actor }}". This could potentially cause issues if the username contains special characters.
Recommend keeping only one of these login commands, preferably using GITHUB_TOKEN since it's the standard authentication method for GitHub Container Registry in GitHub Actions.
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin |
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io \ | ||
| -u "${{ github.actor }}" --password-stdin | ||
| echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin | ||
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin |
There was a problem hiding this comment.
The variable ${{ github.actor }} should be quoted for consistency and to prevent potential issues with special characters in usernames. This line uses an unquoted variable while line 23 properly quotes it as "${{ github.actor }}". Inconsistent quoting can lead to unexpected behavior in shell scripts.
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin | |
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin |
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io \ | ||
| -u "${{ github.actor }}" --password-stdin | ||
| echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin | ||
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin |
There was a problem hiding this comment.
Having two different authentication secrets (GITHUB_TOKEN and GHCR_PAT) for the same purpose creates unnecessary complexity and potential confusion. Since the workflow already has the standard GITHUB_TOKEN configured with proper permissions (packages: write on line 12), the GHCR_PAT secret appears to be redundant. Consider using only one authentication method to simplify maintenance and reduce the risk of misconfiguration.
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin |
🚀 Pull Request: Complete Railway Deployment Optimization
📋 Descripción del Cambio
Este PR implementa la solución completa para el problema de crashes de Railway después de 2 minutos, junto con la funcionalidad completa del dashboard administrativo para el sistema bancario NeuroBank FastAPI.
🎯 Problema Solucionado
✅ Solución Implementada
🔧 Cambios Técnicos Implementados
🚂 Railway Deployment
railway.json] Configuración con health checks y restart policiesstart.sh] Script de inicio inteligente con validacionesDockerfile] Optimización single worker + uvloop📊 Admin Dashboard
admin_transactions.html] Panel transacciones completo con Chart.jsadmin_users.html] Gestión usuarios con búsqueda en tiempo realadmin_reports.html] Reportes avanzados con exportación CSV/Excelrouter.py] Conexiones específicas (no más templates genéricos)🔄 CI/CD Pipeline
.github/workflows/production-pipeline.yml] Pipeline de 8 etapas📚 Documentation Suite
HOTFIX_RAILWAY_CRASH.md] Análisis técnico del problema RailwayWORKFLOW.md] Procedimientos de desarrolloGIT_COMMANDS_HOTFIX.md] Comandos de despliegue🧪 Testing & Validation
✅ Funcionalidad Validada
/healthoperativo🔒 Security Checks
⚡ Performance Tests
🎯 Business Impact
🚀 Deployment Instructions
Pre-merge Checklist
RAILWAY_TOKENconfigurado en GitHub SecretsPost-merge Actions
main👥 Review Requirements
🔍 Areas de Focus para Review
railway.jsonystart.sh🎯 Expected Reviewers
📝 Additional Notes
🔄 Future Improvements
📚 Related Documentation
✅ Ready to Merge Criteria
🎉 Este PR convierte NeuroBank FastAPI en una aplicación bancaria de nivel empresarial con despliegue automático y funcionalidad completa!