Skip to content

[WIP] Update to address feedback on hotfix ci precommit refactor #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Neiland85 merged 1 commit into from
Oct 30, 2025
Merged

[WIP] Update to address feedback on hotfix ci precommit refactor #43

Neiland85 merged 1 commit into from
Oct 30, 2025

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025 •
edited
Loading

  • Analyze the circular import issue between app/database.py and app/models.py
  • Restructure imports to move models import to top-level where init_db() is called
  • Update app/main.py to import models before calling init_db()
  • Update app/tests/conftest.py to import models before calling init_db()
  • Remove the late import from app/database.py init_db() function
  • Run linting and tests to verify the changes work correctly
  • Reply to the review comment

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Oct 30, 2025
Closed
4 tasks
@Neiland85 Neiland85 marked this pull request as ready for review October 30, 2025 14:59
Copilot AI review requested due to automatic review settings October 30, 2025 14:59
Copilot AI reviewed Oct 30, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Neiland85 Neiland85 merged commit 414b00a into hotfix/ci-precommit-refactor-2025.10.30 Oct 30, 2025
1 of 2 checks passed
Copilot AI requested a review from Neiland85 October 30, 2025 14:59
@Neiland85 Neiland85 deleted the copilot/sub-pr-40-another-one branch December 10, 2025 17:07
Neiland85 added a commit that referenced this pull request Dec 13, 2025
@Neiland85
fix(codeql): remove unused imports in router_clean.py
e656500 
- Remove unused typing imports: Any, Dict, List
- Remove unused HTTPException from fastapi
- Remove unused JSONResponse from fastapi.responses

Fixes CodeQL alerts #21, #42, #43
Neiland85 added a commit that referenced this pull request Dec 13, 2025
@Neiland85
fix(codeql): remove unused imports in router_clean.py
f70ec70 
Removes:
- typing.Any, typing.Dict, typing.List (unused)
- fastapi.HTTPException (unused)
- fastapi.responses.JSONResponse (unused)

Closes CodeQL alerts #21, #42, #43
@Neiland85 Neiland85 mentioned this pull request Dec 13, 2025
Merged
22 tasks
Neiland85 added a commit that referenced this pull request Dec 13, 2025
@Neiland85
fix(codeql): remove unused imports in router_clean.py (#116)
b352c86 
Removes:
- typing.Any, typing.Dict, typing.List (unused)
- fastapi.HTTPException (unused)
- fastapi.responses.JSONResponse (unused)

Closes CodeQL alerts #21, #42, #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Neiland85 Neiland85 Awaiting requested review from Neiland85

Assignees

@Neiland85 Neiland85

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Neiland85