Hotfix/ci precommit refactor 2025.10.30 #40

Neiland85 · 2025-10-30T14:34:06Z

CI: Ruff JSON + creación automática de issues; script de ingestión mejorado

Resumen breve:

CI: genera y sube artefacto Ruff JSON en cada ejecución (paso always)
On-failure: crea issues automáticamente desde ruff.json usando GITHUB_TOKEN
Etiquetas aseguradas en fallo: lint, ruff
Script scripts/create_issues_from_logs.py:
- Soporta salida JSON de Ruff (--ruff-json)
- Reintentos con backoff exponencial para gh issue create
- Filtrado de etiquetas inexistentes en el repo para evitar errores
- Compatibilidad con gh y limpieza de lints

Checklist:

Workflow actualizado en .github/workflows/ci.yml
Script probado en local (dry-run y real)
Pre-commit pasa localmente
Validación en CI remoto

Notas:

--template no se usa junto a --body (limitación de gh CLI)
Si faltan labels personalizadas, el script las filtra y crea los issues sin --label

Etiquetas sugeridas: ci, lint, automation.

- Consolidar modelos y Alembic; crear migración inicial no vacía - Limpiar duplicados en services/routers; JWT unificado TokenData - Tests RBAC completos; .env.example; README y docs/RBAC_GUIDE actualizados - Todos los tests pasan: 15 passed

…ELEASE_NOTES.md

… CI)

…cy singletons

…ncy singletons

…cy singleton

… scripts and improve code formatting. Added new steps for code quality checks using Black, Ruff, and Mypy in the CI pipeline. Refactored migration scripts for consistency and clarity. Updated FastAPI routes to improve type hints and formatting.

gitguardian · 2025-10-30T14:34:20Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
21960434	Triggered	Generic Password	`406c3d0`	app/tests/test_auth.py	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

Copilot

Pull Request Overview

This PR implements a complete RBAC (Role-Based Access Control) system for NeuroBank FastAPI Toolkit with comprehensive authentication, user management, and CI/CD pipeline. It adds JWT-based authentication with granular permissions, modern testing infrastructure, and production-ready deployment configurations.

Key Changes:

Complete RBAC implementation with Users, Roles, and Permissions models
JWT authentication system with refresh tokens and permission-based access control
Comprehensive testing suite with 15+ test cases covering auth, users, and roles
Full CI/CD pipeline with quality checks, security scanning, and automated deployment

Reviewed Changes

Copilot reviewed 61 out of 337 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`app/auth/`	JWT authentication system with dependencies and password handling
`app/models.py`	RBAC database models with User-Role-Permission relationships
`app/routers/`	API endpoints for authentication, user management, and role management
`app/services/`	Business logic for user and role operations with error handling
`alembic/`	Database migration system for RBAC schema
`.github/workflows/`	Comprehensive CI/CD pipeline with quality and security checks
`docker-compose.yml`	Development environment with monitoring stack
`Makefile`	Development workflow automation with quality tools

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

logs/terminal_issues.txt

app/auth/jwt.py

app/schemas.py

app/routers/operator.py

app/database.py

app/config.py

Neiland85

Revisados la mitad de los archivos anclados a este bloque y rama.

Neiland85 · 2025-10-30T14:47:46Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2025-10-30T14:47:56Z

@Neiland85 I've opened a new pull request, #41, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Copilot · 2025-10-30T14:52:56Z

@Neiland85 I've opened a new pull request, #42, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-10-30T14:53:12Z

@Neiland85 I've opened a new pull request, #43, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-10-30T14:53:19Z

@Neiland85 I've opened a new pull request, #44, to work on those changes. Once the pull request is ready, I'll request review from you.

Neiland85 · 2025-10-30T14:54:04Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2025-10-30T14:54:13Z

@Neiland85 I've opened a new pull request, #45, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Copilot · 2025-10-30T15:00:12Z

@Neiland85 I've opened a new pull request, #46, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-10-30T15:00:23Z

@Neiland85 I've opened a new pull request, #47, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-10-30T15:00:25Z

@Neiland85 I've opened a new pull request, #48, to work on those changes. Once the pull request is ready, I'll request review from you.

Neiland85 · 2025-10-30T15:00:38Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2025-10-30T15:00:40Z

@Neiland85 I've opened a new pull request, #49, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-10-30T15:00:43Z

@Neiland85 I've opened a new pull request, #50, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-10-30T15:00:49Z

@Neiland85 I've opened a new pull request, #51, to work on those changes. Once the pull request is ready, I'll request review from you.

Neiland85

Revisadas modificaciones de la rama y bloque.

Neiland85 · 2025-10-30T15:50:54Z

Convirtiendo este PR a “Draft”: no tengo permiso/endpoint para cambiar el estado directamente desde aquí. Por favor usa el botón “Convert to draft” en la UI de GitHub en este PR. Alcance actualizado del draft:

CI: genera y sube artefacto Ruff JSON en cada ejecución
On-failure: crea issues automáticamente desde ruff.json (usa GITHUB_TOKEN)
Script: soporte Ruff JSON, backoff, filtrado de etiquetas y compatibilidad gh

Sugerencias de labels para triage: ci, lint, automation.

Cuando lo marques como Draft, puedo actualizar la descripción y checklists si lo necesitas.

* Initial plan * Fix ruff TC006: Add quotes to type expressions in typing.cast() Co-authored-by: Neiland85 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Neiland85 <[email protected]>

…nd actions

Neiland85 · 2025-12-10T16:25:51Z

Closing this PR. The changes no longer align with the updated architecture and dependency model introduced in the December 2025 refactor.

This contribution is now obsolete and would add noise rather than value to the current codebase.

Neiland85 added 12 commits October 30, 2025 11:42

CI: add GitHub Actions workflow (alembic upgrade head + pytest) and R…

9b42c19

…ELEASE_NOTES.md

CI: add Conventional Commits check and Trivy FS scan (CRITICAL)

8c0f67e

Governance: add CODEOWNERS for critical paths (auth, models, alembic,…

da45c27

… CI)

style(user_service): format error messages for Ruff EM101

07fcf44

refactor(password): remove duplicate functions and imports

148320d

refactor(auth): add type hints and dependency singletons (Bandit B008)

6f66db0

refactor(users): consolidate uuid import, add type hints and dependen…

a6efb87

…cy singletons

refactor(roles): consolidate uuid imports, add type hints and depende…

b758d9c

…ncy singletons

refactor(operator): use absolute imports, add type hints and dependen…

6ad0fad

…cy singleton

Fix: repair git integrity, pre-commit hooks, and YAML duplicate keys

dfa5dce

Copilot AI review requested due to automatic review settings October 30, 2025 14:34

Copilot AI reviewed Oct 30, 2025

View reviewed changes

Neiland85 commented Oct 30, 2025

View reviewed changes

Copilot AI mentioned this pull request Oct 30, 2025

[WIP] Fix Railway crashes and improve admin dashboard functionality #41

Merged

Initial plan (#41)

f8015b7

Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Copilot AI mentioned this pull request Oct 30, 2025

refactor: modernize type hints to Python 3.10+ union syntax #42

Closed

Copilot AI mentioned this pull request Oct 30, 2025

[WIP] Update to address feedback on hotfix ci precommit refactor #43

Merged

7 tasks

Copilot AI mentioned this pull request Oct 30, 2025

Use named logger instead of root logger in config.py #44

Closed

Copilot AI mentioned this pull request Oct 30, 2025

Fix linting issues: quote type casts, extract token constant, sort imports, use named logger #45

Closed

Initial plan (#43)

414b00a

Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Copilot AI mentioned this pull request Oct 30, 2025

refactor(config): use named logger instead of root logger #46

Closed

Copilot AI mentioned this pull request Oct 30, 2025

Refactor: Move models import to package level to resolve lazy loading in init_db() #47

Closed

Copilot AI mentioned this pull request Oct 30, 2025

Modernize type annotations: replace Optional with union syntax #48

Closed

Copilot AI mentioned this pull request Oct 30, 2025

Replace hardcoded 'bearer' token type with configuration constant #49

Closed

Copilot AI mentioned this pull request Oct 30, 2025

Use quoted type strings in cast() expressions #50

Closed

Copilot AI mentioned this pull request Oct 30, 2025

Clarify PR workflow limitations in comment response #51

Closed

Neiland85 commented Oct 30, 2025

View reviewed changes

Chore: corrige formato post-ruff

970298f

Neiland85 added ci lint automation labels Oct 30, 2025

Copilot AI and others added 4 commits October 30, 2025 17:16

style(black): format codebase to satisfy CI Black check

170021c

fix(auth): truncate to 72 bytes for bcrypt; deps: bcrypt>=4.0.0

96a94ad

chore(dependabot): enable security updates with grouped PRs for pip a…

8f168f5

…nd actions

Neiland85 closed this Dec 10, 2025

Neiland85 deleted the hotfix/ci-precommit-refactor-2025.10.30 branch December 10, 2025 16:47

Hotfix/ci precommit refactor 2025.10.30 #40

Hotfix/ci precommit refactor 2025.10.30 #40

Uh oh!

Conversation

Neiland85 commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitguardian bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Neiland85 left a comment

Choose a reason for hiding this comment

Uh oh!

Neiland85 commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Neiland85 commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Neiland85 commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

Neiland85 left a comment

Choose a reason for hiding this comment

Uh oh!

Neiland85 commented Oct 30, 2025

Uh oh!

Neiland85 commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Neiland85 commented Oct 30, 2025 •

edited

Loading

gitguardian bot commented Oct 30, 2025 •

edited

Loading