Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025

Addresses review feedback on PR #40 to replace root logger usage with a named logger in app/config.py.

Changes

  • Added module-level named logger: logger = logging.getLogger(__name__)
  • Replaced logging.info() call with logger.info() in Settings.init

Before:

logging.info("🔧 Auto-configured API_KEY for testing environment...")

After:

logger = logging.getLogger(__name__)
# ...
logger.info("🔧 Auto-configured API_KEY for testing environment...")

This follows Python logging best practices by using a named logger (app.config) instead of the root logger, improving log traceability and configurability.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Address feedback on hotfix/ci precommit refactor PR refactor(config): use named logger instead of root logger Oct 30, 2025
Copilot AI requested a review from Neiland85 October 30, 2025 15:06
@Neiland85
Copy link
Owner

This PR has been overtaken by the 2025 architecture refactor.
Closing it with respect, but it is no longer part of the living codebase.

@Neiland85 Neiland85 closed this Dec 10, 2025
@Neiland85 Neiland85 deleted the copilot/sub-pr-40-please-work branch December 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants