Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025

Addresses feedback on PR #40 to use Python 3.10+ union syntax for type annotations instead of typing.Optional.

Changes

  • Replace Optional[InvoiceRequest] with InvoiceRequest | None in app/routers/operator.py
  • Remove unused Optional import from typing module
# Before
from typing import Optional

async def invoice(
    data: Optional[InvoiceRequest] = None,
    ...
) -> InvoiceResponse:

# After
async def invoice(
    data: InvoiceRequest | None = None,
    ...
) -> InvoiceResponse:

Aligns with project's Python 3.11+ requirement and modern type annotation standards.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update hotfix for CI precommit refactor Modernize type annotations: replace Optional with union syntax Oct 30, 2025
Copilot AI requested a review from Neiland85 October 30, 2025 15:06
@Neiland85
Copy link
Owner

Closing this PR. It is now outdated after the full system refactor completed in December 2025.

The project has been unified under a new architecture, updated dependencies, and a consistent configuration model.

Keeping this PR open would introduce inconsistencies and no longer provides technical value.

@Neiland85 Neiland85 closed this Dec 10, 2025
@Neiland85 Neiland85 deleted the copilot/sub-pr-40-b170fc30-ea88-4434-97be-80bbce5f0fe0 branch December 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants