Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025

Addresses review feedback from PR #40 to use quoted type strings in cast() expressions for consistency with modern Python typing practices.

Changes

  • Updated app/auth/jwt.py: Changed cast(str, ...) to cast("str", ...) in both JWT token creation functions
# Before
return cast(str, jwt.encode(...))

# After  
return cast("str", jwt.encode(...))

Affects create_access_token() and create_refresh_token() functions.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix feedback from PR #40 on ci precommit refactor Use quoted type strings in cast() expressions Oct 30, 2025
Copilot AI requested a review from Neiland85 October 30, 2025 15:06
@Neiland85
Copy link
Owner

Closing this PR. The changes no longer align with the updated architecture and dependency model introduced in the December 2025 refactor.

This contribution is now obsolete and would add noise rather than value to the current codebase.

@Neiland85 Neiland85 closed this Dec 10, 2025
@Neiland85 Neiland85 deleted the copilot/sub-pr-40-e1565884-c9f4-4708-bbf3-49f1c67d2363 branch December 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants