-
Notifications
You must be signed in to change notification settings - Fork 0
Fix linting issues: quote type casts, extract token constant, sort imports, use named logger #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…, fix imports, use named logger Co-authored-by: Neiland85 <[email protected]>
|
Closing this PR. It is now outdated after the full system refactor completed in December 2025. The project has been unified under a new architecture, updated dependencies, and a consistent configuration model. Keeping this PR open would introduce inconsistencies and no longer provides technical value. |
|
Closing this PR. The changes no longer align with the updated architecture and dependency model introduced in the December 2025 refactor. This contribution is now obsolete and would add noise rather than value to the current codebase. |
|
Closing this PR. The changes no longer align with the updated architecture and dependency model introduced in the December 2025 refactor. This contribution is now obsolete and would add noise rather than value to the current codebase. |
|
Closing this PR. It is now outdated after the full system refactor completed in December 2025. The project has been unified under a new architecture, updated dependencies, and a consistent configuration model. Keeping this PR open would introduce inconsistencies and no longer provides technical value. |
|
Closing this PR. After the 2025 refactor, these changes are fully superseded and incompatible with the new system design. Keeping it open offers no benefit and only adds unnecessary clutter to the repository. |
|
Closing this PR. After the 2025 refactor, these changes are fully superseded and incompatible with the new system design. Keeping it open offers no benefit and only adds unnecessary clutter to the repository. |
|
Closing this PR. After the 2025 refactor, these changes are fully superseded and incompatible with the new system design. Keeping it open offers no benefit and only adds unnecessary clutter to the repository. |
Addresses linting violations flagged in code review: type annotation quoting (TC006), hardcoded token type (S105), import ordering (I001), modern union syntax (UP045), and root logger usage (LOG015).
Changes
app/auth/jwt.py: Quote type cast expressions per TC006
app/schemas.py: Extract
TOKEN_TYPE_BEARER = "bearer"constant to resolve S105 security warningapp/routers/operator.py:
Optional[InvoiceRequest]withInvoiceRequest | None(PEP 604)app/config.py: Use
logging.getLogger(__name__)instead of root loggerAll ruff checks pass.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.