Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025

Addresses linting violations flagged in code review: type annotation quoting (TC006), hardcoded token type (S105), import ordering (I001), modern union syntax (UP045), and root logger usage (LOG015).

Changes

  • app/auth/jwt.py: Quote type cast expressions per TC006

    # Before: cast(str, jwt.encode(...))
    # After:  cast("str", jwt.encode(...))
  • app/schemas.py: Extract TOKEN_TYPE_BEARER = "bearer" constant to resolve S105 security warning

  • app/routers/operator.py:

    • Sort imports (stdlib before third-party)
    • Replace Optional[InvoiceRequest] with InvoiceRequest | None (PEP 604)
  • app/config.py: Use logging.getLogger(__name__) instead of root logger

All ruff checks pass.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…, fix imports, use named logger

Co-authored-by: Neiland85 <[email protected]>
Copilot AI changed the title [WIP] Optimize Railway deployment to prevent crashes Fix linting issues: quote type casts, extract token constant, sort imports, use named logger Oct 30, 2025
Copilot AI requested a review from Neiland85 October 30, 2025 15:03
@Neiland85
Copy link
Owner

Closing this PR. It is now outdated after the full system refactor completed in December 2025.

The project has been unified under a new architecture, updated dependencies, and a consistent configuration model.

Keeping this PR open would introduce inconsistencies and no longer provides technical value.

@Neiland85 Neiland85 closed this Dec 10, 2025
@Neiland85
Copy link
Owner

Closing this PR. The changes no longer align with the updated architecture and dependency model introduced in the December 2025 refactor.

This contribution is now obsolete and would add noise rather than value to the current codebase.

@Neiland85 Neiland85 reopened this Dec 10, 2025
@Neiland85
Copy link
Owner

Closing this PR. The changes no longer align with the updated architecture and dependency model introduced in the December 2025 refactor.

This contribution is now obsolete and would add noise rather than value to the current codebase.

@Neiland85 Neiland85 closed this Dec 10, 2025
@Neiland85
Copy link
Owner

Closing this PR. It is now outdated after the full system refactor completed in December 2025.

The project has been unified under a new architecture, updated dependencies, and a consistent configuration model.

Keeping this PR open would introduce inconsistencies and no longer provides technical value.

@Neiland85 Neiland85 reopened this Dec 10, 2025
@Neiland85
Copy link
Owner

Closing this PR. After the 2025 refactor, these changes are fully superseded and incompatible with the new system design.

Keeping it open offers no benefit and only adds unnecessary clutter to the repository.

@Neiland85 Neiland85 closed this Dec 10, 2025
@Neiland85
Copy link
Owner

Closing this PR. After the 2025 refactor, these changes are fully superseded and incompatible with the new system design.

Keeping it open offers no benefit and only adds unnecessary clutter to the repository.

@Neiland85 Neiland85 reopened this Dec 10, 2025
@Neiland85
Copy link
Owner

Closing this PR. After the 2025 refactor, these changes are fully superseded and incompatible with the new system design.

Keeping it open offers no benefit and only adds unnecessary clutter to the repository.

@Neiland85 Neiland85 closed this Dec 10, 2025
@Neiland85 Neiland85 deleted the copilot/sub-pr-40-one-more-time branch December 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants