Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025

Addresses feedback from PR #40 to avoid calling logging methods on the root logger directly.

Changes

  • Added module-level named logger: logger = logging.getLogger(__name__)
  • Updated logging.info() call to use logger.info() in Settings.init()
# Before
logging.info("🔧 Auto-configured API_KEY for testing environment...")

# After
logger = logging.getLogger(__name__)
# ...
logger.info("🔧 Auto-configured API_KEY for testing environment...")

This follows Python logging best practices by using a named logger scoped to app.config instead of the root logger.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Add changes to address PR #40 feedback Use named logger instead of root logger in config.py Oct 30, 2025
Copilot AI requested a review from Neiland85 October 30, 2025 14:58
@Neiland85
Copy link
Owner

This PR has been overtaken by the 2025 architecture refactor.
Closing it with respect, but it is no longer part of the living codebase.

@Neiland85 Neiland85 closed this Dec 10, 2025
@Neiland85 Neiland85 deleted the copilot/sub-pr-40-yet-again branch December 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants