Translations update from Hosted Weblate#630
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughBulk localization updates: large English additions (homePage, header, modals), numerous French string corrections and wording tweaks, added Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/locales/list/en-us.json (1)
138-146: Optional copy polish for queue status string.Line 142 reads a bit heavy and title-cased; consider sentence case for readability.
✏️ Suggested copy tweak
- "inQueue": "In Queue: {{count}} User(s) Ahead Of You", + "inQueue": "In queue: {{count}} user(s) ahead of you",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/locales/list/en-us.json` around lines 138 - 146, Update the "inQueue" locale string to use sentence case and clearer phrasing: replace the current title-cased "In Queue: {{count}} User(s) Ahead Of You" with a concise sentence-case variant such as "You are in queue: {{count}} user(s) ahead of you" (or "You are in the queue: {{count}} users ahead of you") in the "statusHeader" -> "inQueue" entry to improve readability; ensure the interpolation token {{count}} remains unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/locales/list/en-us.json`:
- Around line 138-146: Update the "inQueue" locale string to use sentence case
and clearer phrasing: replace the current title-cased "In Queue: {{count}}
User(s) Ahead Of You" with a concise sentence-case variant such as "You are in
queue: {{count}} user(s) ahead of you" (or "You are in the queue: {{count}}
users ahead of you") in the "statusHeader" -> "inQueue" entry to improve
readability; ensure the interpolation token {{count}} remains unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 29c8a57e-3dfd-441e-b614-f4ce26905480
📒 Files selected for processing (5)
src/locales/list/ar-ps.jsonsrc/locales/list/be-tarask.jsonsrc/locales/list/en-us.jsonsrc/locales/list/es-es.jsonsrc/locales/list/fr-FR.json
✅ Files skipped from review due to trivial changes (3)
- src/locales/list/ar-ps.json
- src/locales/list/es-es.json
- src/locales/list/be-tarask.json
🚧 Files skipped from review as they are similar to previous changes (1)
- src/locales/list/fr-FR.json
414198d to
e424c29
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/locales/list/en-us.json`:
- Around line 167-173: Add the missing "loggingIn" key under the "loginPage"
object in the base locale file (en-us.json) so t("loginPage.loggingIn") in
LoginPage.tsx resolves; update the "loginPage" block to include "loggingIn" with
the appropriate string (e.g., "Logging in...") matching other locales.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: aa79463f-f4c1-405f-8df3-5f4f8fc69b1f
📒 Files selected for processing (9)
src/locales/list/ar-ps.jsonsrc/locales/list/be-tarask.jsonsrc/locales/list/de-de.jsonsrc/locales/list/en-us.jsonsrc/locales/list/es-es.jsonsrc/locales/list/fr-FR.jsonsrc/locales/list/pl-pl.jsonsrc/locales/list/pt-br.jsonsrc/locales/list/uw-uw.json
✅ Files skipped from review due to trivial changes (3)
- src/locales/list/ar-ps.json
- src/locales/list/be-tarask.json
- src/locales/list/pl-pl.json
🚧 Files skipped from review as they are similar to previous changes (2)
- src/locales/list/es-es.json
- src/locales/list/fr-FR.json
| "loginPage": { | ||
| "title": "Login to continue", | ||
| "emailOrUsernameAndTag": "Email / username:tag", | ||
| "password": "Password", | ||
| "login": "Login", | ||
| "createAccountInstead": "Create an account instead" | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether loginPage.loggingIn is used and currently missing in en-us.
rg -n --type=ts --type=tsx 'loginPage\.loggingIn|t\("loginPage\.loggingIn"' src
rg -n '"loginPage"\s*:' src/locales/list/en-us.json -A12
rg -n '"loggingIn"\s*:' src/locales/list/*.jsonRepository: Nerimity/nerimity-web
Length of output: 1891
🏁 Script executed:
#!/bin/bash
# Better search for loginPage.loggingIn usage in TypeScript/JavaScript files
# Ignore the tsx type error and search directly
rg 'loginPage\.loggingIn' src --type-add 'ts:*.{ts,tsx}' -n
rg 't\("loginPage\.loggingIn' src --type-add 'ts:*.{ts,tsx}' -n
rg 'loggingIn' src --type-add 'ts:*.{ts,tsx}' -n | head -20Repository: Nerimity/nerimity-web
Length of output: 1590
🏁 Script executed:
#!/bin/bash
# Check for i18n configuration and fallback logic
fd -e ts -e tsx -e js | xargs grep -l "i18n\|fallback\|LocaleProvider" src | head -10
rg 'fallback|defaultLocale' src --type-add 'ts:*.{ts,tsx}' -n | head -10
cat src/locales/list/en-us.json | head -30Repository: Nerimity/nerimity-web
Length of output: 2407
Add missing loginPage.loggingIn key to en-us.json base locale.
The code in src/pages/LoginPage.tsx:127 uses t("loginPage.loggingIn"), but this key is missing from en-us.json. While the i18n system falls back to en-gb (configured at src/index.tsx:229), the key should be present in the base locale for consistency—all 20+ other locale files include it.
Proposed patch
"loginPage": {
"title": "Login to continue",
"emailOrUsernameAndTag": "Email / username:tag",
"password": "Password",
"login": "Login",
- "createAccountInstead": "Create an account instead"
+ "createAccountInstead": "Create an account instead",
+ "loggingIn": "Logging in…"
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "loginPage": { | |
| "title": "Login to continue", | |
| "emailOrUsernameAndTag": "Email / username:tag", | |
| "password": "Password", | |
| "login": "Login", | |
| "createAccountInstead": "Create an account instead" | |
| } | |
| "loginPage": { | |
| "title": "Login to continue", | |
| "emailOrUsernameAndTag": "Email / username:tag", | |
| "password": "Password", | |
| "login": "Login", | |
| "createAccountInstead": "Create an account instead", | |
| "loggingIn": "Logging in…" | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/locales/list/en-us.json` around lines 167 - 173, Add the missing
"loggingIn" key under the "loginPage" object in the base locale file
(en-us.json) so t("loginPage.loggingIn") in LoginPage.tsx resolves; update the
"loginPage" block to include "loggingIn" with the appropriate string (e.g.,
"Logging in...") matching other locales.
Currently translated at 100.0% (1006 of 1006 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/fr/
Currently translated at 5.7% (58 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/en_US/
Currently translated at 100.0% (1007 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/fr/
Currently translated at 100.0% (1007 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/es/
Currently translated at 49.8% (502 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/ar_PS/
Currently translated at 100.0% (1007 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/be_TARASK/
Currently translated at 48.7% (491 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/uw_UW/
Currently translated at 100.0% (1007 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/pt_BR/
Currently translated at 100.0% (1007 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/fr/
Currently translated at 100.0% (1007 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/de/
Currently translated at 100.0% (1007 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/pl/
Currently translated at 100.0% (1007 of 1007 strings) Translation: Nerimity/Nerimity Web Translate-URL: https://hosted.weblate.org/projects/nerimity/nerimity-web/fr/
e424c29 to
e523586
Compare
Translations update from Hosted Weblate for Nerimity/Nerimity Web.
Current translation status:
Summary by CodeRabbit