Skip to content

Translate Bump Modal#631

Merged
SupertigerDev merged 1 commit intoNerimity:mainfrom
1enify:i18n-1
Mar 30, 2026
Merged

Translate Bump Modal#631
SupertigerDev merged 1 commit intoNerimity:mainfrom
1enify:i18n-1

Conversation

@1enify
Copy link
Copy Markdown
Contributor

@1enify 1enify commented Mar 30, 2026

What does this PR do?

  • Translate Bump Modal

Screenshots

See #625

Did you test your code?

Yes

Additional context

Decided to cut down to just the modal since the latter from #625 is not that urgent

Checklist

  • Changes are clear, concise, and easy to review
  • Code has been tested and works as intended
  • Text/content changes support internationalization (i18n)
  • Any new user-facing strings are properly localized

Summary by CodeRabbit

Release Notes

  • New Features
    • Added British English localization for the server bump modal interface.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 06fc8cb7-5a4e-487e-9e97-0f223ff74183

📥 Commits

Reviewing files that changed from the base of the PR and between 10c3e85 and b2dba04.

📒 Files selected for processing (2)
  • src/components/explore/ExploreServers.tsx
  • src/locales/list/en-gb.json

📝 Walkthrough

Walkthrough

This PR adds localization support to the ServerBumpModal component by replacing hardcoded English strings with translation keys and adding corresponding English translations to support multiple languages.

Changes

Cohort / File(s) Summary
Component Localization
src/components/explore/ExploreServers.tsx
Updated ServerBumpModal button label and title from hardcoded strings to localized translation calls using t() function, preserving dynamic name substitution.
Translation Strings
src/locales/list/en-gb.json
Added new explore.bumpModal translation keys with title ("Bump {{name}}") and bumpButton ("Bump") entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • PR #227: Adds "bump server" context-menu option that opens ServerBumpModal, which is the component being localized in this PR.
  • PR #271: Broadly internationalizes ExploreServers component, directly affecting the same file being modified here.
  • PR #370: Updates explore-related translation keys and modifies ServerBumpModal localization in the same component.

Poem

🐰 A modal needs words that the world understands,
So we traded hardcoded strings for translation's sweet hands,
Now "Bump" speaks in tongues, {{name}} dances with flair—
What once was English-bound now floats everywhere! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: translating the Bump Modal with localized strings for button and title.
Description check ✅ Passed The description follows the template with all required sections completed, though some sections are brief. All checklist items are checked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SupertigerDev SupertigerDev merged commit f9d9c1c into Nerimity:main Mar 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants