Skip to content

Update bottom pane icons#641

Open
1enify wants to merge 2 commits intoNerimity:mainfrom
1enify:bottom-pane-icons
Open

Update bottom pane icons#641
1enify wants to merge 2 commits intoNerimity:mainfrom
1enify:bottom-pane-icons

Conversation

@1enify
Copy link
Copy Markdown
Contributor

@1enify 1enify commented Apr 2, 2026

What does this PR do?

  • Adds new icons on the Homepage

Screenshots

Screenshot_20260402_171956

Did you test your code?

Yes

Additional context

Nerimity server link now opens in a new page. Also, I don't know if the monochrome icon implementation is perfect, seems rather bloated to me. Please optimize if there is a way.

Checklist

  • Changes are clear, concise, and easy to review
  • Code has been tested and works as intended

Summary by CodeRabbit

  • New Features
    • Expanded footer social media links to include Bluesky, Mastodon, Reddit, Threads, YouTube, Product Hunt, and Itch.io.
    • Updated the Nerimity social link to direct to the external platform.
    • All external social links now open in new tabs for seamless browsing.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

📝 Walkthrough

Walkthrough

The PageFooter component's social links section is updated to replace an internal Nerimity link with an external one using a custom LogoMono icon component, and expands the social presence by replacing the Ko-fi link with seven new external social platforms (Bluesky, Mastodon, Reddit, Threads, YouTube, Product Hunt, and Itch.io), each with corresponding SVG assets and opening in new tabs.

Changes

Cohort / File(s) Summary
Nerimity Social Link Refactor
src/components/PageFooter.tsx
Changes the Nerimity social entry from an internal /i/nerimity link with SocialIcon to an external https://nerimity.com/i/nerimity link rendered with inline LogoMono component inside a styled NerimityIcon wrapper, adding grayscale/opacity hover effects.
Social Links Expansion
src/components/PageFooter.tsx
Replaces the single Ko-fi link with seven new external social links (Bluesky, Mastodon, Reddit, Threads, YouTube, Product Hunt, Itch.io), each configured to open in a new tab with corresponding SVG icon assets from /assets/.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

  • Add social profiles links to homepage footer #526: Previously established the SocialIcon/SocialLinks structure and added initial social links to the footer; this PR builds upon that foundation by converting the Nerimity link to external and expanding the social link set further.
  • Add monochrome home button #638: Introduced and exported the LogoMono component that is now utilized in this PR for rendering the Nerimity social icon inside the PageFooter.

Poem

🐰 Social wings spread wide and far,
New links gleam like a guiding star,
Ko-fi bids farewell with grace,
As Bluesky and friends find their place,
The footer hops to platforms galore! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Update bottom pane icons' is vague and generic, using non-descriptive language that doesn't convey the specific nature of the changes (social links replacement, external links, new icon set). Clarify the title to specify the main change, such as 'Replace Ko-fi link with multiple social media links in footer' or 'Update PageFooter social links and add external social media icons'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description follows the required template structure with all key sections completed: What does this PR do (with added icons mentioned), screenshots included, testing confirmation, additional context about the Nerimity link and icon implementation, and mostly completed checklist items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/PageFooter.tsx`:
- Around line 77-85: The Nerimity icon-only link in PageFooter.tsx (the
CustomLink wrapping NerimityIcon/LogoMono) lacks an accessible name; update the
CustomLink element to include an explicit aria-label (e.g., aria-label="Nerimity
homepage") and mark the decorative icon element(s) as aria-hidden="true" on
NerimityIcon or LogoMono so screen readers read the label and ignore the visual
SVG.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 12cf697c-5e91-4336-bdb3-0b7afbf984f2

📥 Commits

Reviewing files that changed from the base of the PR and between 20602e3 and f1a3b72.

⛔ Files ignored due to path filters (7)
  • public/assets/bluesky.svg is excluded by !**/*.svg
  • public/assets/itchio.svg is excluded by !**/*.svg
  • public/assets/mastodon.svg is excluded by !**/*.svg
  • public/assets/producthunt.svg is excluded by !**/*.svg
  • public/assets/reddit.svg is excluded by !**/*.svg
  • public/assets/threads.svg is excluded by !**/*.svg
  • public/assets/youtube.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • src/components/PageFooter.tsx

Comment on lines 77 to +85
<CustomLink
class={socialLinkStyle}
href="/i/nerimity"
href="https://nerimity.com/i/nerimity"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={appLogoUrl()} alt="nerimity" />
<NerimityIcon>
<LogoMono />
</NerimityIcon>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add an accessible name for the Nerimity icon link.

At Line 77, this icon-only link has no text/alt, so screen readers may announce it as unlabeled. Please add an explicit aria-label (and keep the icon decorative).

♿ Suggested fix
           <CustomLink
             class={socialLinkStyle}
             href="https://nerimity.com/i/nerimity"
+            aria-label="Nerimity"
             target="_blank"
             rel="noopener noreferrer"
           >
-            <NerimityIcon>
+            <NerimityIcon aria-hidden="true">
               <LogoMono />
             </NerimityIcon>
           </CustomLink>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<CustomLink
class={socialLinkStyle}
href="/i/nerimity"
href="https://nerimity.com/i/nerimity"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={appLogoUrl()} alt="nerimity" />
<NerimityIcon>
<LogoMono />
</NerimityIcon>
<CustomLink
class={socialLinkStyle}
href="https://nerimity.com/i/nerimity"
aria-label="Nerimity"
target="_blank"
rel="noopener noreferrer"
>
<NerimityIcon aria-hidden="true">
<LogoMono />
</NerimityIcon>
</CustomLink>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/PageFooter.tsx` around lines 77 - 85, The Nerimity icon-only
link in PageFooter.tsx (the CustomLink wrapping NerimityIcon/LogoMono) lacks an
accessible name; update the CustomLink element to include an explicit aria-label
(e.g., aria-label="Nerimity homepage") and mark the decorative icon element(s)
as aria-hidden="true" on NerimityIcon or LogoMono so screen readers read the
label and ignore the visual SVG.

@SupertigerDev
Copy link
Copy Markdown
Member

Did you remove the Kofi icon? If yes, you didn't clarify in the PR

@1enify
Copy link
Copy Markdown
Contributor Author

1enify commented Apr 2, 2026

Oh, yea. I just thought it doesn't count as social media, I can add it back alongside Boosty if you want

@SupertigerDev
Copy link
Copy Markdown
Member

i guess thats true, but pls make sure to mention these things in the PR. i will merge maybe tmrw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants