Skip to content

Update bottom pane icons #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1enify wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update bottom pane icons #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1711790
Add new icons
Apr 2, 2026
f1a3b72
Update icons on the homepage
Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions public/assets/bluesky.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions public/assets/itchio.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions public/assets/mastodon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 20 additions & 0 deletions public/assets/producthunt.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
40 changes: 40 additions & 0 deletions public/assets/reddit.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions public/assets/threads.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions public/assets/youtube.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
70 changes: 66 additions & 4 deletions src/components/PageFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { appLogoUrl } from "@/common/worldEvents";
import { emojiUnicodeToShortcode, unicodeToTwemojiUrl } from "@/emoji";
import { Emoji } from "./markup/Emoji";
import { JSXElement } from "solid-js";
import { LogoMono } from "../LogoMono";

const FooterContainer = styled(FlexRow)`
gap: 10px;
Expand All @@ -37,6 +38,17 @@ const SocialIcon = styled("img")`
opacity: 100%;
}
`;
const NerimityIcon = styled("svg")`
width: 28px;
height: 28px;
filter: grayscale(100%);
opacity: 65%;
transition: 0.2s;
&:hover {
filter: grayscale(15%);
opacity: 100%;
}
`;

const socialLinkStyle = css`
display: flex;
Expand Down Expand Up @@ -64,11 +76,13 @@ export default function PageFooter() {
<SocialLinks>
<CustomLink
class={socialLinkStyle}
href="/i/nerimity"
href="https://nerimity.com/i/nerimity"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={appLogoUrl()} alt="nerimity" />
<NerimityIcon>
<LogoMono />
</NerimityIcon>
Comment on lines 77 to +85
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add an accessible name for the Nerimity icon link.

At Line 77, this icon-only link has no text/alt, so screen readers may announce it as unlabeled. Please add an explicit aria-label (and keep the icon decorative).

♿ Suggested fix 
           <CustomLink
             class={socialLinkStyle}
             href="https://nerimity.com/i/nerimity"
+            aria-label="Nerimity"
             target="_blank"
             rel="noopener noreferrer"
           >
-            <NerimityIcon>
+            <NerimityIcon aria-hidden="true">
               <LogoMono />
             </NerimityIcon>
           </CustomLink>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<CustomLink
class={socialLinkStyle}
href="/i/nerimity"
href="https://nerimity.com/i/nerimity"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={appLogoUrl()} alt="nerimity" />
<NerimityIcon>
<LogoMono />
</NerimityIcon>
<CustomLink
class={socialLinkStyle}
href="https://nerimity.com/i/nerimity"
aria-label="Nerimity"
target="_blank"
rel="noopener noreferrer"
>
<NerimityIcon aria-hidden="true">
<LogoMono />
</NerimityIcon>
</CustomLink>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/components/PageFooter.tsx` around lines 77 - 85, The Nerimity icon-only
link in PageFooter.tsx (the CustomLink wrapping NerimityIcon/LogoMono) lacks an
accessible name; update the CustomLink element to include an explicit aria-label
(e.g., aria-label="Nerimity homepage") and mark the decorative icon element(s)
as aria-hidden="true" on NerimityIcon or LogoMono so screen readers read the
label and ignore the visual SVG.

</CustomLink>
<CustomLink
class={socialLinkStyle}
Expand All @@ -88,11 +102,59 @@ export default function PageFooter() {
</CustomLink>
<CustomLink
class={socialLinkStyle}
href="https://ko-fi.com/supertiger"
href="https://bsky.app/profile/nerimity.com"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={"/assets/bluesky.svg"} alt="bluesky" />
</CustomLink>
<CustomLink
class={socialLinkStyle}
href="https://mastodon.social/@nerimity"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={"/assets/mastodon.svg"} alt="mastodon" />
</CustomLink>
<CustomLink
class={socialLinkStyle}
href="https://www.reddit.com/r/nerimitychat"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={"/assets/reddit.svg"} alt="reddit" />
</CustomLink>
<CustomLink
class={socialLinkStyle}
href="https://www.threads.com/@nerimity"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={"/assets/threads.svg"} alt="threads" />
</CustomLink>
<CustomLink
class={socialLinkStyle}
href="https://www.youtube.com/@Nerimity"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={"/assets/youtube.svg"} alt="youtube" />
</CustomLink>
<CustomLink
class={socialLinkStyle}
href="https://www.producthunt.com/posts/nerimity"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={"/assets/producthunt.svg"} alt="product hunt" />
</CustomLink>
<CustomLink
class={socialLinkStyle}
href="https://supertigerdev.itch.io/nerimity"
target="_blank"
rel="noopener noreferrer"
>
<SocialIcon src={"/assets/kofi.svg"} alt="ko-fi" />
<SocialIcon src={"/assets/itchio.svg"} alt="itchio" />
</CustomLink>
</SocialLinks>
</FlexRow>
Expand Down
Loading