Polish translation – corrections #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, this is my first contribution of GitHub so I hope I did everything correctly. I decided to come up with some corrections to the polish translation primarily because of the translation of "clear" in the current "values" section – a literal translation of the current "wyczyść" would something like "clean it up" and is very confusing. For example, in case of water leakage sensor a new user or one without experience would rather understand "wyczyść" as an indication that there is water leakage to clean, when in fact it's a translation of state of there not being any leakage at all. Also, "tampered" as "manipulacja" has no meaning – it even leaves no clue what can be happening with the device. Changes described above are the most important and I think should be a priority. The rest that I suggested are mostly to make it sound more natural. Additionally, in "ota" and "settingsSchemaDescriptions" I've come up with changes to make the translations more informative and easier to understand (based on the reference file https://github.com/Nerivec/zigbee2mqtt-windfront/blob/main/src/i18n/locales/en.json ). I also unified the abbreviation for second where applicable. I hope it will come as helpful. Should there be any questions, I'll try to answer as soon as possible.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is my first contribution of GitHub so I hope I did everything correctly.
I decided to come up with some corrections to the polish translation primarily because of the translation of "clear" in the current "values" section – a literal translation of the current "wyczyść" would something like "clean it up" and is very confusing. For example, in case of water leakage sensor a new user or one without experience would rather understand "wyczyść" as an indication that there is water leakage to clean, when in fact it's a translation of state of there not being any leakage at all. Also, "tampered" as "manipulacja" has no meaning – it even leaves no clue what can be happening with the device.
Changes described above are the most important and I think should be a priority. The rest that I suggested are mostly to make it sound more natural. Additionally, in "ota" and "settingsSchemaDescriptions" I've come up with changes to make the translations more informative and easier to understand (based on the reference file https://github.com/Nerivec/zigbee2mqtt-windfront/blob/main/src/i18n/locales/en.json ). I also unified the abbreviation for second where applicable.
I hope it will come as helpful. Should there be any questions, I'll try to answer as soon as possible.